IQSS/10840 - DatasetTypesIT test fix #10841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
reviewed
Sep 12, 2024
There was a problem hiding this comment.
I see @sekmiller is already looking at this but consider this an "approve" from me. 😄
sekmiller
approved these changes
Sep 12, 2024
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Simple fix for a random test failure - when the generated alphanumeric name is randomly all numeric, which is not allowed.
Which issue(s) this PR closes:
Closes #10840
Special notes for your reviewer:
Simple fix - we've had this class of issue before.
Suggestions on how to test this: Just verify the test passes - probably not worth trying to see the problem on the current branch - https://jenkins.dataverse.org/blue/organizations/jenkins/IQSS-Dataverse-Develop-PR/detail/PR-10632/16/tests/ shows one occurence.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: