-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix backwards newest oldest sort order #11000
Conversation
@stevenwinship - I see the JsonParserTest.parseDataverseDTO test failure - can you update from develop to get the fix for it (I assume that's the problem). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - a simple swap of the two cases to get the order right. There is a test failing, presumably unrelated, but we should verify in QA.
@stevenwinship I'm trying to push the PR to Internal and received a failure in jenkins: [ERROR] Failures: Could you please update your PR with the latest from Dev. Thanks! Edit: Just saw the update on the PR - will retest with latest build |
@stevenwinship Came across an observation while testing the fix in Internal. Reproduction Steps:
Note: I uploaded 1 csv file on Nov 4th, 2024 and published the dataset. I pushed the fix to internal then I added 9 more files to the same dataset with Deposited date: Nov. 6, 2024. |
My guess is that internal has Order By Folder turned on. With that, the sorting (newest/oldest/alphabetical, etc.) is done within each folder. |
Thanks @qqmyers that did the trick. Merging PR Screen.Recording.2024-11-06.at.12.08.23.PM.mov |
What this PR does / why we need it: Sort order in UI on dataset file listing is backwards for Newest and Oldest
Which issue(s) this PR closes:#10742
Special notes for your reviewer: fully tested the comparator and determined it was just a UI issue
Suggestions on how to test this: Test using UI
On a dataset file listing, click "Sort -> Newest"
The resulting order should be newest first.
On a dataset file listing, click "Sort -> Oldest"
The resulting order should be oldest first.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Included
Additional documentation: