fix search files to return latest published citation #11051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenwinship
added
Original size: 10
FY25 Sprint 11
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
sekmiller
reviewed
Dec 6, 2024
| @@ -1328,7 +1328,8 @@ public SolrInputDocuments toSolrDocs(IndexableDataset indexableDataset, Set<Long | |||
| } | |||
| LocalDate embargoEndDate=null; | |||
| LocalDate retentionEndDate=null; | |||
| final String datasetCitation = dataset.getCitation(); | |||
| final String datasetCitation = (dataset.isReleased() && dataset.getReleasedVersion() != null) ? | |||
There was a problem hiding this comment.
You wouldn't ever expect that a released dataset wouldn't have a released version unless maybe there's a deaccessioned version, maybe?
sekmiller
approved these changes
Dec 6, 2024
|
Fix looks good Screen.Recording.2024-12-20.at.10.39.18.AM.mov |
ofahimIQSS
deleted the
10735-search-dataset-name-and-dataset-citation-different
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Search should not return DRAFT information when a dataset is updated after publishing
Which issue(s) this PR closes:#10735
Special notes for your reviewer:
Suggestions on how to test this: Follow the steps listed in the issue.
open in browser: http://localhost:8080/api/v1/search?q=*&type=file&sort=date&order=desc&per_page=10&start=0&subtree=root
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: Included
Additional documentation: