Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment out /dv/lang to prevent verbose logging #11063

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Dec 4, 2024

What this PR does / why we need it:

When I created this pull request:

... I didn't test it in a fresh environment where I hadn't loaded languages.zip.

In this PR, I'm commenting out /dev/lang and updating the instructions to explain that you should uncomment the /dev/lang line if you want multiple languages.

Which issue(s) this PR closes:

Special notes for your reviewer:

You can preview the docs at https://dataverse-guide--11063.org.readthedocs.build/en/11063/container/running/demo.html#multiple-languages

Suggestions on how to test this:

Make sure the two compose files still work. We could retest the language setup but it should be unchanged.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

No, the release note in #11043 is generic enough that it's fine as-is.

Additional documentation:

See https://dataverse-guide--11063.org.readthedocs.build/en/11063/container/running/demo.html#multiple-languages

@pdurbin pdurbin added Feature: Internationalization Component: Containers Anything related to cloudy Dataverse, shipped in containers. Size: 0.5 A percentage of a sprint. 0.35 hours FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) labels Dec 4, 2024
@pdurbin pdurbin added this to the 6.5 milestone Dec 4, 2024
@stevenwinship stevenwinship self-assigned this Dec 4, 2024
@pdurbin pdurbin changed the title comment out /dev/lang to prevent verbose logging comment out /dv/lang to prevent verbose logging Dec 4, 2024
@stevenwinship stevenwinship removed their assignment Dec 4, 2024
@ofahimIQSS ofahimIQSS self-assigned this Dec 4, 2024
@cmbz cmbz added the FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) label Dec 5, 2024
@ofahimIQSS
Copy link
Contributor

No issues found during testing. Tested to ensure /dv/lang messaging no longer floods the server.log file. Was able to follow guides to set up french language on local without any issues.
image

@ofahimIQSS ofahimIQSS merged commit 82dad99 into develop Dec 5, 2024
3 checks passed
@ofahimIQSS ofahimIQSS deleted the 11043-lang branch December 5, 2024 15:44
@ofahimIQSS ofahimIQSS removed their assignment Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers. Feature: Internationalization FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) Size: 0.5 A percentage of a sprint. 0.35 hours
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

In containers, "No property file named Bundle_en found in /dv/lang, using untranslated values"
4 participants