-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extended search API #11097
extended search API #11097
Conversation
src/main/java/edu/harvard/iq/dataverse/search/SolrSearchResult.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/harvard/iq/dataverse/search/SolrSearchResult.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RE: The thumbnail url is already included in the search result for datasets |
example of dataset with image_url: example of Tab File with new fields: |
This comment has been minimized.
This comment has been minimized.
<field name="canDownloadFile" type="boolean" stored="true" indexed="false" multiValued="false"/> | ||
<field name="variableCount" type="plong" stored="true" indexed="false" multiValued="false"/> | ||
<field name="observations" type="plong" stored="true" indexed="false" multiValued="false"/> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added variable count and observations for completeness.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a small tweak to the release notes, but otherwise looks good.
Tests are passing - merging pr |
What this PR does / why we need it: For the SPA, in order to display the lock icon, and tags/categories information for items in the collection page, we should add some extra properties to each file item from search api once type=file.
For tabular files, there are some properties needed additionally.
Also, for dataset search api type=dataset, because datasets' thumbnail should be displayed, an extra property is needed.
Which issue(s) this PR closes: #11027
Special notes for your reviewer: Dataset field "thumbnail" is already included as "image_url" so it was not added
Suggestions on how to test this: See SearchIT
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Included
Additional documentation: