IQSS/11126 payara6.2024.12 #11128
Open
IQSS/11126 payara6.2024.12 #11128
+844
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
force-pushed
the
IQSS/11126-Payara6.2024.12
branch
from
261bba6 to
bf5728e
Compare
|
@poikilotherm - any thoughts on the MailSessionProducerIT test failure? I don't see how the code changes could affect this but perhaps something has changed in Payara/its config? (I looked at another PR where this passes and I think the hostname is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Updates to Payara 6.2024.12, fixing a few places where JSF now appears to send a null rather than an empty string, causing some new NPEs.
Which issue(s) this PR closes:
Special notes for your reviewer: FWIW: It looks like just copying the domain across to the new version works so we may only want to show 'Option 1' form the release notes. I originally did 'Option2' - just copying the parts of domain.xml and other files to the new domain which has some advantages (easier to diff against the latest payara domain.xml, gets new cacerts file, makes it possible to track payara domain.xml changes in github (against /conf/payara/domain.xml), etc.) but it's definitely more work/more confusing.
Suggestions on how to test this: Check new installs, docker, upgrade instructions - basically regression testing and testing instructions, there shouldn't be any functional changes. Could confirm that the current v6.5 war does not work with Payara 6.2024.12, but I think that's well enough known.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: references to 6.2024.6 changed to 6.2024.12 in docs