Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#24 add DataCite DOI support #2964

Merged
merged 28 commits into from
Mar 14, 2016
Merged

#24 add DataCite DOI support #2964

merged 28 commits into from
Mar 14, 2016

Conversation

sekmiller
Copy link
Contributor

Updated Documentation for Installers Guide included

@sekmiller
Copy link
Contributor Author

sekmiller commented Feb 23, 2016 •
edited by scolapasta
Loading

Related Issues:
#24
#3013

RFI Checklist

  • Functionality completed as described in FRD
  • Dependencies, risks, assumptions in FRD addressed
  • Unit tests completed
  • Deployment requirements identified (e.g., SQL scripts, indexing)
  • Documentation completed
  • All code checkins completed
  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

@sekmiller sekmiller added this to the 4.3 milestone Feb 23, 2016
@eaquigley
Copy link
Contributor

Waiving usability testing as it is not necessary for this functionality.

@pdurbin
Copy link
Member

pdurbin commented Feb 25, 2016

I see docs have already been marked as complete but @posixeleni just pointed out that DataCite customers can subscribe to updates at http://status.datacite.org and I guess we could mention this in our docs. Just a suggestion, really. Perhaps someone could add it to the list at #2944.

@pdurbin
Copy link
Member

pdurbin commented Feb 25, 2016

@sekmiller as we discussed, please update https://github.com/IQSS/dataverse/blob/24-add-DataCite-DOI-Support/doc/sphinx-guides/source/installation/prep.rst#architecture-and-components

If you'd like me to help you create a dedicated page for "Persistent indentifer service" (whoops, please fix that typo while you're in there), please let me know.

@pdurbin pdurbin assigned sekmiller and unassigned scolapasta Feb 25, 2016
@sekmiller
Copy link
Contributor Author

Handing back to Gustavo for code review. Will make a small edit to documentation as noted by Phil above.

@sekmiller sekmiller assigned scolapasta and unassigned sekmiller Feb 26, 2016
@scolapasta scolapasta assigned kcondon and unassigned scolapasta Feb 26, 2016
@pdurbin pdurbin mentioned this pull request Mar 1, 2016
Closed
@kcondon
Copy link
Contributor

kcondon commented Mar 2, 2016

Found several issues needing attention:
#2981, #2983, #2988, #2989, #2990 , #2982

@kcondon kcondon assigned sekmiller and unassigned kcondon Mar 2, 2016
@sekmiller
Copy link
Contributor Author

@scolapasta The conflict is most likely on the Dataset.xhtml. Per our discussion about the warning we show to users if the publish is going to also register the dataset, @eaquigley asked me to remove it completely (for DataCite and EZID instances) - it's a sausage-making message that the users don't care about. They should be aware that publishing a dataset will include having a public doi.

@scolapasta scolapasta assigned kcondon and unassigned sekmiller Mar 9, 2016
@kcondon kcondon assigned sekmiller and unassigned kcondon Mar 14, 2016
@sekmiller sekmiller assigned kcondon and unassigned sekmiller Mar 14, 2016
@sekmiller
Copy link
Contributor Author

Checkins completed. Ready for testing

@kcondon kcondon assigned scolapasta and unassigned kcondon Mar 14, 2016
@kcondon
Copy link
Contributor

kcondon commented Mar 14, 2016

OK to merge

scolapasta added a commit that referenced this pull request Mar 14, 2016
@scolapasta
Merge pull request #2964 from IQSS/24-add-DataCite-DOI-Support
a69052b 
#24 add data cite doi support
@scolapasta scolapasta merged commit a69052b into develop Mar 14, 2016
pdurbin
pdurbin reviewed Apr 20, 2016
View reviewed changes
doc/sphinx-guides/source/installation/prep.rst
@@ -56,7 +56,7 @@ When planning your installation you should be aware of the following components
- PostgreSQL: a relational database.
- Solr: a search engine. A Dataverse-specific schema is provided.
- SMTP server: for sending mail for password resets and other notifications.
- Persistent indentifer service: DOI support is provided. An EZID subscription is required for production use.
- Persistent indentifier service: DOI support is provided. An EZID subscription or DataCite account is required for production use.
Copy link
Member

@pdurbin pdurbin Apr 20, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah! It's still spelled wrong! From "indentifer" to "indentifier". D'oh! I added a reminder to #2944.

@mheppler mheppler deleted the 24-add-DataCite-DOI-Support branch September 27, 2016 18:39
@qqmyers qqmyers mentioned this pull request Oct 16, 2019
Closed
@qqmyers qqmyers mentioned this pull request Oct 7, 2020
Merged
@pdurbin pdurbin changed the title #24 add data cite doi support #24 add DataCite DOI support Apr 15, 2022
@pdurbin pdurbin mentioned this pull request Apr 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scolapasta scolapasta

Labels
None yet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
8 participants
@sekmiller @eaquigley @pdurbin @kcondon @raprasad @bencomp @scolapasta @mheppler