Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2966 Update "Welcome..."/create account-related notifications #2976

Merged
merged 3 commits into from
Feb 26, 2016

Conversation

mheppler
Copy link
Contributor

RFI Checklist

Please fill out (1) and (2) before submitting the Pull Request

(1) - Related Issues:

List/link to the issues in this Pull Request
#2966 Notifications: Welcome to 4.0 Notification Needs to Change

(2) - Pull Request Checklist

  • N/A... Functionality completed as described in FRD
  • N/A... Dependencies, risks, assumptions in FRD addressed
  • N/A... Unit tests completed
  • N/A... Deployment requirements identified (e.g., SQL scripts, indexing)
  • N/A... Documentation completed
  • All code checkins completed

(3) - Review Checklist

To be filled out after the Pull Request is submitted.

  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived - waived
  • Support testing completed or waived - waived
  • Merged with develop branch and resolved conflicts

@mheppler
Copy link
Contributor Author

Page/Requirements Issue# Commit#
Account Pg Notification, Create Account
Change notification msg to open Contact Dataverse Support popup, improve text in general #2966 4e44d10, 421f821
Email Notification, Create Account
Change notification msg to not include '4.0' or 'support@dataverse.org', to improve text in general, and add dynamic (installation/version) link to User Guide #2966 f35995a, 4e44d10

@scolapasta scolapasta added this to the 4.3 milestone Feb 26, 2016
@scolapasta scolapasta assigned kcondon and unassigned scolapasta Feb 26, 2016
@kcondon kcondon assigned scolapasta and unassigned kcondon Feb 26, 2016
scolapasta added a commit that referenced this pull request Feb 26, 2016
#2966 Update "Welcome..."/create account-related notifications
@scolapasta scolapasta merged commit 36f6147 into develop Feb 26, 2016
@@ -215,7 +215,7 @@ notification.email.assign.role.subject=Dataverse: You have been assigned a role
notification.email.revoke.role.subject=Dataverse: Your role has been revoked

notification.email.greeting=Hello, \n
notification.email.welcome=Welcome to Dataverse 4.0! Please take a look around, try everything out, and contact support@dataverse.org if you have questions or feedback.
notification.email.welcome=Welcome to Dataverse! Get started by adding or finding data. Have questions? Check out the User Guide at {0}/{1}/user/ or contact Dataverse Support for assistance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has already been merged but rather than hard-coding "Dataverse Support" here, we could get it dynamically from some of the work done in #2088. This would require some backend work, of course.

@mheppler mheppler deleted the 2966-4.0notification branch September 27, 2016 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants