Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added backend support for alternate citation dates #2606 #3000

Merged
merged 6 commits into from
Mar 8, 2016

Conversation

scolapasta
Copy link
Contributor

RFI Checklist

Before submitting the pull request, fill out sections (1.) Related Issues and (2.) Pull Request Checklist.

1. Related Issues

List and link to the issues in this Pull Request.

- #2606 Add Backend Support for Changing Citation Date

2. Pull Request Checklist

  • Functionality completed as described in FRD - github issue
  • Dependencies, risks, assumptions in FRD addressed - github issue
  • Unit tests completed - n/a
  • Deployment requirements identified (e.g., SQL scripts, indexing) - added update script
  • Documentation completed - added
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived - reviewed by @michbarsinai
  • Testing requirements completed
  • Usability testing completed or waived - waived
  • Support testing completed or waived - waived
  • Merged with develop branch and resolved conflicts

@scolapasta scolapasta added this to the 4.3 milestone Mar 4, 2016
@scolapasta scolapasta assigned kcondon and unassigned michbarsinai Mar 7, 2016
michbarsinai and others added 5 commits March 7, 2016 22:56
…refine looks into JSON body of the wrapped response, if indeed the wrapped response is of type application/json
Conflicts:
	scripts/database/upgrades/upgrade_v4.2.4_to_4.3.sql
@scolapasta
Copy link
Contributor Author

For dev / test environment, these are the additional statements to run:

-- Add new foreign ket to dataset for citation date (from datasetfieldtype)
ALTER TABLE dataset ADD COLUMN citationdatedatasetfieldtype_id bigint;

ALTER TABLE dataset
ADD CONSTRAINT fk_dataset_citationdatedatasetfieldtype_id FOREIGN KEY (citationdatedatasetfieldtype_id)
REFERENCES datasetfieldtype (id) MATCH SIMPLE
ON UPDATE NO ACTION ON DELETE NO ACTION;

@kcondon kcondon assigned scolapasta and unassigned kcondon Mar 8, 2016
@kcondon
Copy link
Contributor

kcondon commented Mar 8, 2016

Ready for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants