Refactor superuser API endpoint to migrate Shib user to builtin/local account #3120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had coder's remorse over the quality of work I put into the superuser API endpoint to migrate Shib user to builtin/local account in #2915 and confessed to @scolapasta at #3025 (comment) . We agreed that the code should be refactored, which I did in this pull request. Nothing changes in terms of how the API works. Docs at http://guides.dataverse.org/en/2939-shib/installation/shibboleth.html#converting-shibboleth-users-to-local are still accurate. The code was cleaned up and centralized, which means it will be easier to build a GUI around this feature in the future. I'm reopening #2915 since it hasn't shipped yet.
1. Related Issues
2. Pull Request Checklist
3. Review Checklist
After the pull request has been submitted, fill out this section.