-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2594 contributing #3730
2594 contributing #3730
Conversation
Changes from top to bottom of this doc: - Say it's ok to email support privately about ideas. - Standardize on calling GitHub issue the "issue tracker". - Link to http://chat.dataverse.org rather than freenode web interface and explicitly mention IRC logs. - When writing an issue, include steps to reproduce, version number, and screenshots. - Explain that many more attachment formats are now accepted. - Link to new documentation section of dev guide. - Link to doc folder in "develop" rather than "master".
- Remove mention of FRDs, which we don't create anymore. - Delete "feature request process" and feature-request-process.png - http://datascience.iq.harvard.edu/dataverse/support was a 404 - Add link to roadmap. - Add section on usability testing. - Remove section on issue labels (out of date). - Remove section on milestones (out of date). - Add note about emailing support if no response to a GitHub comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
CONTRIBUTING.md
Outdated
Before you start coding, please reach out to us either on our [dataverse-community Google Group][], [IRC][], or via support@dataverse.org to make sure the effort is well coordinated and we avoid merge conflicts. | ||
|
||
[dataverse-community Google Group]: https://groups.google.com/group/dataverse-community | ||
[IRC]: http://irclog.iq.harvard.edu/dataverse/today | ||
[IRC]: http://chat.dataverse.org | ||
|
||
If your pull request is not assigned to anyone in a timely manner, please reach out. The assignee is responsible for evaluating the pull request and deciding whether or not to merge it in. Please try to make it easy to merge in pull requests. Tests are great. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just re-read "The assignee is responsible for evaluating the pull request and deciding whether or not to merge it in" and this is an out-of-date holdover from an old process. I'll update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fixed in 69e3788.
RFI Checklist
1. Related Issues
2. Pull Request Checklist
3. Review Checklist
After the pull request has been submitted, fill out this section.