Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2594 contributing #3730

Merged
merged 4 commits into from
Mar 29, 2017
Merged

2594 contributing #3730

merged 4 commits into from
Mar 29, 2017

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Mar 28, 2017

RFI Checklist

1. Related Issues


2. Pull Request Checklist

  • Functionality completed as described in FRD
  • Dependencies, risks, assumptions in FRD addressed
  • Unit tests completed
  • Deployment requirements identified (e.g., SQL scripts, indexing)
  • Documentation completed
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

Changes from top to bottom of this doc:

- Say it's ok to email support privately about ideas.
- Standardize on calling GitHub issue the "issue tracker".
- Link to http://chat.dataverse.org rather than freenode web interface
  and explicitly mention IRC logs.
- When writing an issue, include steps to reproduce, version number, and
  screenshots.
- Explain that many more attachment formats are now accepted.
- Link to new documentation section of dev guide.
- Link to doc folder in "develop" rather than "master".
- Remove mention of FRDs, which we don't create anymore.
- Delete "feature request process" and feature-request-process.png
- http://datascience.iq.harvard.edu/dataverse/support was a 404
- Add link to roadmap.
- Add section on usability testing.
- Remove section on issue labels (out of date).
- Remove section on milestones (out of date).
- Add note about emailing support if no response to a GitHub comment.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 9.717% when pulling 69c0224 on 2594-contributing into f6e81e3 on develop.

Copy link
Contributor

@djbrooke djbrooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

CONTRIBUTING.md Outdated
Before you start coding, please reach out to us either on our [dataverse-community Google Group][], [IRC][], or via support@dataverse.org to make sure the effort is well coordinated and we avoid merge conflicts.

[dataverse-community Google Group]: https://groups.google.com/group/dataverse-community
[IRC]: http://irclog.iq.harvard.edu/dataverse/today
[IRC]: http://chat.dataverse.org

If your pull request is not assigned to anyone in a timely manner, please reach out. The assignee is responsible for evaluating the pull request and deciding whether or not to merge it in. Please try to make it easy to merge in pull requests. Tests are great. :)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just re-read "The assignee is responsible for evaluating the pull request and deciding whether or not to merge it in" and this is an out-of-date holdover from an old process. I'll update it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fixed in 69e3788.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 9.717% when pulling 69e3788 on 2594-contributing into f6e81e3 on develop.

@kcondon kcondon merged commit 85a2152 into develop Mar 29, 2017
@kcondon kcondon deleted the 2594-contributing branch March 29, 2017 15:58
@pdurbin pdurbin added this to the 4.6.2 - Tabular Mapping milestone May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants