Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4053 Reverted EditDatafilesPage.restrictFiles #4069

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

matthew-a-dunlap
Copy link
Contributor

@matthew-a-dunlap matthew-a-dunlap commented Aug 11, 2017

Used the non-command functionality for restricting files as this does not break due to the lack of editDataset permissions. The transaction still completes due to later transactions.

Related Issues

Pull Request Checklist

  • Unit [tests][] completed
  • Integration [tests][]:
  • Deployment requirements, [SQL updates][], [Solr updates][], etc.: None
  • [Documentation][docs] completed
  • Merged latest from "develop" [branch][] and resolved conflicts

Used the non-command functionality for restricting files as this does not break due to the lack of editDataset permissions. The transaction still completes due to later transactions.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0002%) to 12.058% when pulling dbb93c0 on 4053-restrict-file-create-dataset into dd55c08 on develop.

@matthew-a-dunlap matthew-a-dunlap changed the title Reverted EditDatafilesPage.restrictFiles 4053 Reverted EditDatafilesPage.restrictFiles Aug 11, 2017
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're reverting the old pre-command behavior, which sounds fine for now. Some day we should figure out how to bring the command back into the picture.

@kcondon kcondon merged commit 959859d into develop Aug 17, 2017
@kcondon kcondon deleted the 4053-restrict-file-create-dataset branch August 17, 2017 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants