4726 docker it iterating #4727
Merged
4726 docker it iterating #4727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-a-dunlap
approved these changes
Jun 5, 2018
There was a problem hiding this comment.
Looks good to me! Not sure if specific review was wanted from @landreev
Unrelated to rest of branch, made a quick fix to a docs link on the Add Dataset Page. Original link failed to point to the correct subsection of the guides page.
This was referenced Jun 11, 2018
michbarsinai
approved these changes
Jun 17, 2018
landreev
approved these changes
Jun 18, 2018
pdurbin
modified the milestones:
5.0 - DataTags and Support for Sensitive Data,
4.9.1 - Postgres upgrade, Bug Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist