-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binder now supports Dataverse DOIs #4714 #6453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
reviewed
Dec 12, 2019
choldgraf
reviewed
Dec 12, 2019
Co-Authored-By: Chris Holdgraf <choldgraf@gmail.com>
djbrooke
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with @pdurbin and made some edits. On to QA!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull requests helps ensure that installations of Dataverse are aware that they can now use https://mybinder.org to spin up Jupyter Notebooks based on DOIs of datasets in Dataverse as described in my write up linked from https://twitter.com/philipdurbin/status/1204472858413371392
Which issue(s) this PR relates to:
Relates to #4714
Special notes for your reviewer:
At this time we cannot create an external tool for Binder in Dataverse because we can only pass DOIs as query parameters and Binder requires DOIs to be in paths.
Suggestions on how to test this:
From https://groups.google.com/d/msg/dataverse-community/K7vKWSPLaQY/8go3fvV3AwAJ
To try it out, go to https://mybinder.org and click the dropdown to select "Dataverse DOI". Then type in the DOI of a dataset hosted in an installation of Dataverse and click "Launch" (screenshot 1, attached).
After a while, an instance of Jupyter Lab will appear with the files from the Dataverse dataset (screenshot 2).
From Jupyter Lab you can either open an existing Jupyter Notebook that is one of the files in the Dataverse dataset or you can create a new Jupyter Notebook. (No screenshot. Hmm! Time to upload a Jupyter notebook to the dataset!)
To return to the dataset landing page in Dataverse from Jupyter Lab, click "visit repo" (screenshot 3).
Does this PR introduce a user interface change?:
No.
Is there a release notes update needed for this change?:
Yes, suggestion added.
Additional documentation:
Dataverse is now listed at https://binderhub.readthedocs.io/en/latest/developer/repoproviders.html#supported-repoproviders