6262 show proper number of ds inlinking dv #6564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
approved these changes
Jan 23, 2020
|
@sekmiller this doesn't handle when there are dataverse in a linked dataverses (nor datasets in those dataverses, etc). We would need some recursion for this, but is likely what is needed to truly resolve this issue. |
|
Moving back to team dev based on comment from @scolapasta above |
scolapasta
reviewed
Jan 29, 2020
| return false; | ||
| } | ||
|
|
||
| private List<String> findLinkingDataversePaths(Dataverse dataverse, Boolean self) { |
There was a problem hiding this comment.
why is this an object and not a primitive boolean?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR will display the datasets owned by a linked dataverse in the linking dataverse
Which issue(s) this PR closes:
Closes #6262
Special notes for your reviewer:
None
Suggestions on how to test this:
Link a DV containing datasets and see that the datasets are displayed in the linking DV.
Does this PR introduce a user interface change?:
no
Is there a release notes update needed for this change?:
added as 6262-release-notes.md
Additional documentation:
NA