prevent database deadlocks #6846 #6865 #7020 #7030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At tech hours yesterday we talked about a new lead that the deadlock may happen between setting the index time and setting the permission time. Closing. People should keep an eye on #6865. |
|
As an added comment, we did spin this one up, and as expected, there were still deadlocks. (i.e. I was about to close, since I hadn't seen @pdurbin already do that) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The pull request adds a sleep in the code leading up to
UPDATE DVOBJECT SET INDEXTIMEwhich sometimes leads to database deadlocks, especially when the full API test suite is run. The sleep is added to the onSuccess method of the FinalizeDatasetPublicationCommand.Which issue(s) this PR closes:
Closes #6846 Test Failing
Closes #6865 Internal Exception: org.postgresql.util.PSQLException: ERROR: deadlock detected
Closes #7020 Get API test suite passing 😴 😴 😴
Special notes for your reviewer:
Suggestions on how to test this:
Deploy the branch. See if the 3 second sleep is bothersome during normal user operations.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
None.