Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7684 - fix class import for HTTPException in DeletePidCommand #7686

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

poikilotherm
Copy link
Contributor

What this PR does / why we need it:
Fixing a small wrong import of a class, most likely happened by accident.

Which issue(s) this PR closes:

Closes #7684

Special notes for your reviewer:
None

Suggestions on how to test this:
Seems hard to force a HTTPException by DataCite. This might be tested with some more advanced stuff like response mocking.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope

Is there a release notes update needed for this change?:
Nope

Additional documentation:

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now matches what's thrown at

public void deleteIdentifier(DvObject dvObject) throws IOException, HttpException {
!

@kcondon kcondon self-assigned this Mar 18, 2021
@kcondon kcondon merged commit b20ffa0 into IQSS:develop Mar 18, 2021
@djbrooke djbrooke added this to the 5.4 milestone Mar 18, 2021
@poikilotherm poikilotherm deleted the 7684-fix-httpexception-import branch December 15, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong class import for HTTPException in DeletePidCommand
4 participants