7639 mpconfig dbsetting #7739
Closed
7639 mpconfig dbsetting #7739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingsServiceBean.Key` enum use of it. IQSS#7639 By adding these scopes as a data structure, we enable a documented approach to define key names inside of MicroProfile Config Sources. Instead of a collection of Strings, this is much more explicit. Due to its iterable nature, it may be used to generate documentation down the road. Changing names gets more trackable.
…m MPCONFIG. IQSS#7639 When the settings service is asked for config data, it will now look up if there is data available from MPCONFIG and let that take precedence over any database entry. - To build the key under which the data should be living inside MPCONFIG, it's using the formerly introduced keys and scopes. - If no key can be found for a given String (because the calling codebase uses an informally defined setting), it will try to lookup the data in scope called "unscoped", with a lowercased key, stripped from any leading colon. We can now: 1. Retrieve data for formerly defined keys as untyped String data 2. If the setting requires some kind of comma separated list or JSON, it's still simple string data, thus retrievable. We cannot (yet): 1. Retrieve the sort of "mapped" data, where key names are suffixed with a map key from properly scoped entries in MPCONFIG, only from unscoped or database. 2. Retrieve localized settings, which are handled in a more specialized way.
poikilotherm
added
Type: Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request will
Flaws (not yet) addressed:
SystemConfig,SettingsServiceBeanandSettingsWrapper, this PR as is will not allow to use MPCONFIG values within JSF.SettingServiceBean.Keyshould actually live in a file on its own. It's huge and the concept needs to be applied more generally. This would involve in a lot of cruft change works and make a lot of noise.Which issue(s) this PR closes:
Closes #7639
Closes #7680
Special notes for your reviewer:
This is a work in progress.
Suggestions on how to test this:
TBD
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No, it will not.
Is there a release notes update needed for this change?:
Later.
Additional documentation:
None yet.