Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQSS/8321 Accessibility #8322

Merged

Commits on Dec 6, 2021

  1. Configuration menu
    Copy the full SHA
    d66c61c View commit details
    Browse the repository at this point in the history
  2. remove role="menu"

    per https://web.archive.org/web/20190116170516/https://www.marcozehe.de/2018/09/22/wai-aria-menus-and-why-you-should-generally-avoid-using-them/
    - it doesn't seem like we're using this role as intended in most cases,
    so I'm doing a blanket removal to see if there are adverse UI impacts or
    new accessibility issues being reported. With this role, menus like the
    Edit menu in the files table report an issue (from AXE) with the menu
    not containing child elements with the right role (i.e. menuitem), and a
    seemingly spurious 'li elements must be contained in a ul or ol' error.
    
    Conflicts:
    	src/main/webapp/file.xhtml
    qqmyers committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    92061c2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9cd4ca4 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. Configuration menu
    Copy the full SHA
    734bd63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aee596b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3b11799 View commit details
    Browse the repository at this point in the history
  4. versions tab - duplicate link ids

    id="versionLink" appears once per row in the versionTable - not sure why
    that is only an accessibility issue (i.e. not a problem for jsp
    generation). The id wasn't used anywhere that I can see.
    qqmyers committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    97f6395 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    762b7a7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cdcca13 View commit details
    Browse the repository at this point in the history
  7. dataverse page, gen info, metadata fields: color contrast for disabled

    When editing the metadata allowed in a dataset, if you select 'Use
    browse/search facets from <root dataverse>, all of the disabled entries
    have insufficient contrast. One option to fix this would be increasing
    the contrast, however, setting aria-disabled=true also works - disabled
    entries don't have to have high contrast.
    qqmyers committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    85c0637 View commit details
    Browse the repository at this point in the history
  8. dataset files fragment - add unique row labels for selecting

    works via PrimeFaces to assign a label to the row selection to avoid a
    ARIA toggle fields must have an accessible name
    qqmyers committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    f887c9d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5149657 View commit details
    Browse the repository at this point in the history
  10. dataset files table - unique titles for preview links

    Links with the same name should have similar purpose
    
    This change uses the i18n names of individual previewers for the preview
    button, which reduces the ambiguity, but doesn't give the preview in
    each row a unique title. (I.e. two images still have 'View Image' as the
    title, but 'Read Text' for a text preview would now be different.)
    
    We could add the filename to the title to make this fully unique, either
    with/without using the previewer names.
    
    Note: Deque says this is an issue unless the links are 'intentionally
    ambiguous' - not sure if that includes assuming the row context is
    enough.
    qqmyers committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    9a5252f View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. dataset metadata edit tab - fix labels

    the existing code had labeling, but the ids labels used to refence
    inputs were incorrect.
    
    This commit also adds a label for CVV fields - (not multival in compound
    fields which may or may not exist in the wild).
    qqmyers committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    107d77f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    79336b8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4bb9777 View commit details
    Browse the repository at this point in the history
  4. titles for sharre entries

    qqmyers committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    f332465 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6bffda3 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. main page icon - remove tabindex=1

    tabindex>0 generated a warning. In this case, the tabindex is on a
    <span> within an <a> which already causes a tab stop. So I've removed
    the tabindex altogether, which I think just removes a redundant stop on
    this element.
    qqmyers committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    b575136 View commit details
    Browse the repository at this point in the history
  2. main page - menu support form not in li

    Since the support form in in the menu's <ul>, it needs to be wrapped in
    a <li> to avoid a warning
    qqmyers committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    46dfdec View commit details
    Browse the repository at this point in the history
  3. main header -user menu remove role=menu

    same as for other role=menu
    qqmyers committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    0849bea View commit details
    Browse the repository at this point in the history
  4. header - label for user dropdown link

    used an aria-labelledby to associate the a element with the text in the
    a child element (#userDisplayIfoTitle).
    qqmyers committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    a099e48 View commit details
    Browse the repository at this point in the history
  5. color updates

    Colors are a complex issue - this commit has a few changes that remove
    Axe warnings related to links, muted text, and some earning/danger
    labels. Several of these, e.g. labels come from bootstrap and so will
    change with bootstrap version. In many cases, Axe can't determine
    whether there is an issue due to gradient backgrounds and/or overlapping
    elements.
    qqmyers committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    e7ff8bd View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. Configuration menu
    Copy the full SHA
    9c64f5e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc48506 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1464a55 View commit details
    Browse the repository at this point in the history
  4. typo

    qqmyers committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    f60f34b View commit details
    Browse the repository at this point in the history
  5. login page = labels and h1 element

    added css to keep font-size 30px for h1 Login element (which it was when
    it was an h2 element)
    qqmyers committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    9f6a7fc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ec929d3 View commit details
    Browse the repository at this point in the history
  7. header - label

    mismatched id/aria-labelledby values
    qqmyers committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    77012fa View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3ab0f75 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3df52e9 View commit details
    Browse the repository at this point in the history
  10. edit files table - unique ids

    qqmyers committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    9f97755 View commit details
    Browse the repository at this point in the history
  11. remove unnecessary/wrong passthrough

    this applies the File Count label to the individual row tds rather than
    to the header which shows a file count.
    qqmyers committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    8ca6257 View commit details
    Browse the repository at this point in the history
  12. edit files table - add row labels, fix labels, fix empty header sr label

    the row labels avoid the select check boxes having a warning about no
    text
    the labels/message boxes for the file name and directory label inputs
    were broken
    the facet for the empty header stops a warning about no screen reader
    accessible text for that metadata column header
    qqmyers committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    e8e2528 View commit details
    Browse the repository at this point in the history
  13. Merge remote-tracking branch 'IQSS/develop' into IQSS/8321-Accessibility

    Conflicts:
    	src/main/webapp/filesFragment.xhtml
    qqmyers committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    c2b1529 View commit details
    Browse the repository at this point in the history
  14. login page - lost updates

    fixes to label for= values
    h2 -> h1 for lvel-one heading
    qqmyers committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    7adc4c9 View commit details
    Browse the repository at this point in the history
  15. typo

    qqmyers committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    f06b10f View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. reduce size of h1 elements

    qqmyers committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    6f50c62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9405df3 View commit details
    Browse the repository at this point in the history
  3. use pixel size instead of em

    qqmyers committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    30f48e8 View commit details
    Browse the repository at this point in the history