-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IQSS/8321 Accessibility #8322
IQSS/8321 Accessibility #8322
Commits on Dec 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d66c61c - Browse repository at this point
Copy the full SHA d66c61cView commit details -
per https://web.archive.org/web/20190116170516/https://www.marcozehe.de/2018/09/22/wai-aria-menus-and-why-you-should-generally-avoid-using-them/ - it doesn't seem like we're using this role as intended in most cases, so I'm doing a blanket removal to see if there are adverse UI impacts or new accessibility issues being reported. With this role, menus like the Edit menu in the files table report an issue (from AXE) with the menu not containing child elements with the right role (i.e. menuitem), and a seemingly spurious 'li elements must be contained in a ul or ol' error. Conflicts: src/main/webapp/file.xhtml
Configuration menu - View commit details
-
Copy full SHA for 92061c2 - Browse repository at this point
Copy the full SHA 92061c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cd4ca4 - Browse repository at this point
Copy the full SHA 9cd4ca4View commit details
Commits on Dec 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 734bd63 - Browse repository at this point
Copy the full SHA 734bd63View commit details -
Configuration menu - View commit details
-
Copy full SHA for aee596b - Browse repository at this point
Copy the full SHA aee596bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b11799 - Browse repository at this point
Copy the full SHA 3b11799View commit details -
versions tab - duplicate link ids
id="versionLink" appears once per row in the versionTable - not sure why that is only an accessibility issue (i.e. not a problem for jsp generation). The id wasn't used anywhere that I can see.
Configuration menu - View commit details
-
Copy full SHA for 97f6395 - Browse repository at this point
Copy the full SHA 97f6395View commit details -
Configuration menu - View commit details
-
Copy full SHA for 762b7a7 - Browse repository at this point
Copy the full SHA 762b7a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdcca13 - Browse repository at this point
Copy the full SHA cdcca13View commit details -
dataverse page, gen info, metadata fields: color contrast for disabled
When editing the metadata allowed in a dataset, if you select 'Use browse/search facets from <root dataverse>, all of the disabled entries have insufficient contrast. One option to fix this would be increasing the contrast, however, setting aria-disabled=true also works - disabled entries don't have to have high contrast.
Configuration menu - View commit details
-
Copy full SHA for 85c0637 - Browse repository at this point
Copy the full SHA 85c0637View commit details -
dataset files fragment - add unique row labels for selecting
works via PrimeFaces to assign a label to the row selection to avoid a ARIA toggle fields must have an accessible name
Configuration menu - View commit details
-
Copy full SHA for f887c9d - Browse repository at this point
Copy the full SHA f887c9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5149657 - Browse repository at this point
Copy the full SHA 5149657View commit details -
dataset files table - unique titles for preview links
Links with the same name should have similar purpose This change uses the i18n names of individual previewers for the preview button, which reduces the ambiguity, but doesn't give the preview in each row a unique title. (I.e. two images still have 'View Image' as the title, but 'Read Text' for a text preview would now be different.) We could add the filename to the title to make this fully unique, either with/without using the previewer names. Note: Deque says this is an issue unless the links are 'intentionally ambiguous' - not sure if that includes assuming the row context is enough.
Configuration menu - View commit details
-
Copy full SHA for 9a5252f - Browse repository at this point
Copy the full SHA 9a5252fView commit details
Commits on Dec 10, 2021
-
dataset metadata edit tab - fix labels
the existing code had labeling, but the ids labels used to refence inputs were incorrect. This commit also adds a label for CVV fields - (not multival in compound fields which may or may not exist in the wild).
Configuration menu - View commit details
-
Copy full SHA for 107d77f - Browse repository at this point
Copy the full SHA 107d77fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79336b8 - Browse repository at this point
Copy the full SHA 79336b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bb9777 - Browse repository at this point
Copy the full SHA 4bb9777View commit details -
Configuration menu - View commit details
-
Copy full SHA for f332465 - Browse repository at this point
Copy the full SHA f332465View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bffda3 - Browse repository at this point
Copy the full SHA 6bffda3View commit details
Commits on Dec 13, 2021
-
main page icon - remove tabindex=1
tabindex>0 generated a warning. In this case, the tabindex is on a <span> within an <a> which already causes a tab stop. So I've removed the tabindex altogether, which I think just removes a redundant stop on this element.
Configuration menu - View commit details
-
Copy full SHA for b575136 - Browse repository at this point
Copy the full SHA b575136View commit details -
main page - menu support form not in li
Since the support form in in the menu's <ul>, it needs to be wrapped in a <li> to avoid a warning
Configuration menu - View commit details
-
Copy full SHA for 46dfdec - Browse repository at this point
Copy the full SHA 46dfdecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0849bea - Browse repository at this point
Copy the full SHA 0849beaView commit details -
header - label for user dropdown link
used an aria-labelledby to associate the a element with the text in the a child element (#userDisplayIfoTitle).
Configuration menu - View commit details
-
Copy full SHA for a099e48 - Browse repository at this point
Copy the full SHA a099e48View commit details -
Colors are a complex issue - this commit has a few changes that remove Axe warnings related to links, muted text, and some earning/danger labels. Several of these, e.g. labels come from bootstrap and so will change with bootstrap version. In many cases, Axe can't determine whether there is an issue due to gradient backgrounds and/or overlapping elements.
Configuration menu - View commit details
-
Copy full SHA for e7ff8bd - Browse repository at this point
Copy the full SHA e7ff8bdView commit details
Commits on Dec 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9c64f5e - Browse repository at this point
Copy the full SHA 9c64f5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc48506 - Browse repository at this point
Copy the full SHA fc48506View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1464a55 - Browse repository at this point
Copy the full SHA 1464a55View commit details -
Configuration menu - View commit details
-
Copy full SHA for f60f34b - Browse repository at this point
Copy the full SHA f60f34bView commit details -
login page = labels and h1 element
added css to keep font-size 30px for h1 Login element (which it was when it was an h2 element)
Configuration menu - View commit details
-
Copy full SHA for 9f6a7fc - Browse repository at this point
Copy the full SHA 9f6a7fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec929d3 - Browse repository at this point
Copy the full SHA ec929d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77012fa - Browse repository at this point
Copy the full SHA 77012faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ab0f75 - Browse repository at this point
Copy the full SHA 3ab0f75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3df52e9 - Browse repository at this point
Copy the full SHA 3df52e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f97755 - Browse repository at this point
Copy the full SHA 9f97755View commit details -
remove unnecessary/wrong passthrough
this applies the File Count label to the individual row tds rather than to the header which shows a file count.
Configuration menu - View commit details
-
Copy full SHA for 8ca6257 - Browse repository at this point
Copy the full SHA 8ca6257View commit details -
edit files table - add row labels, fix labels, fix empty header sr label
the row labels avoid the select check boxes having a warning about no text the labels/message boxes for the file name and directory label inputs were broken the facet for the empty header stops a warning about no screen reader accessible text for that metadata column header
Configuration menu - View commit details
-
Copy full SHA for e8e2528 - Browse repository at this point
Copy the full SHA e8e2528View commit details -
Merge remote-tracking branch 'IQSS/develop' into IQSS/8321-Accessibility
Conflicts: src/main/webapp/filesFragment.xhtml
Configuration menu - View commit details
-
Copy full SHA for c2b1529 - Browse repository at this point
Copy the full SHA c2b1529View commit details -
fixes to label for= values h2 -> h1 for lvel-one heading
Configuration menu - View commit details
-
Copy full SHA for 7adc4c9 - Browse repository at this point
Copy the full SHA 7adc4c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f06b10f - Browse repository at this point
Copy the full SHA f06b10fView commit details
Commits on Jan 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6f50c62 - Browse repository at this point
Copy the full SHA 6f50c62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9405df3 - Browse repository at this point
Copy the full SHA 9405df3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30f48e8 - Browse repository at this point
Copy the full SHA 30f48e8View commit details