Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7469 request access feedback #8341

Merged
merged 9 commits into from
Jan 24, 2022
Merged

7469 request access feedback #8341

merged 9 commits into from
Jan 24, 2022

Conversation

sekmiller
Copy link
Contributor

What this PR does / why we need it: Adds feedback to the user when they request access to a restricted file.

  • A Success Banner message when there's a valid access request made
  • An info tag added the the files table for any active request which will remain until the request is acted upon by the admin
  • The general Request Access button will be removed when there are no more files that can be requested (all are public or all have been granted access or all have pending requests or any combination of the above)
  • A warning message will be displayed if a request is made on a file that is already public or has an active request (this is possible if there is still a file or files for which a valid request may be made alongside others that are public, etc.)

Which issue(s) this PR closes:

Closes #7469 People requesting access to a file need visible feedback when a request is sent

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:
Screen Shot 2022-01-10 at 3 50 04 PM
Screen Shot 2022-01-10 at 11 45 52 AM
Screen Shot 2022-01-06 at 10 35 56 AM

@pdurbin pdurbin self-assigned this Jan 12, 2022
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think the code looks fine. I'm sending back, however, because I noticed some strange behavior.

Step 1. From the file table, click the access button, then "Request Access"

Screen Shot 2022-01-12 at 2 43 39 PM

Step 2. Observe a spinner and no change to the file table

Screen Shot 2022-01-12 at 2 43 49 PM

Step 3. Later, if you refresh the page, you'll see that the access request actually went through. The problem is the lack of feedback in Step 2.

@pdurbin pdurbin assigned sekmiller and unassigned pdurbin Jan 12, 2022
@sekmiller
Copy link
Contributor Author

I missed adding the update to the single file request button. It should be ok now.

@sekmiller sekmiller removed their assignment Jan 12, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 18.918% when pulling 4253780 on 7469-request-access-feedback into 6fa131f on develop.

@scolapasta
Copy link
Contributor

@sekmiller @djbrooke approved, but it says Meging is blocked once changes are approved. Does @pdurbin need to do the actual (re) approval? I do see an option to "dismiss review" and could try that to see if that clears it.

@djbrooke
Copy link
Contributor

@scolapasta yes, it's fine to dismiss the review in this case.

@kcondon kcondon self-assigned this Jan 24, 2022
@scolapasta scolapasta dismissed pdurbin’s stale review January 24, 2022 16:19

@pdurbin is out and I (re0 reviewed in his place

@kcondon kcondon merged commit afe7543 into develop Jan 24, 2022
@kcondon kcondon deleted the 7469-request-access-feedback branch January 24, 2022 19:15
@djbrooke djbrooke added this to the 5.10 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

People requesting access to a file need visible feedback when request is sent
6 participants