-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7469 request access feedback #8341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think the code looks fine. I'm sending back, however, because I noticed some strange behavior.
Step 1. From the file table, click the access button, then "Request Access"
Step 2. Observe a spinner and no change to the file table
Step 3. Later, if you refresh the page, you'll see that the access request actually went through. The problem is the lack of feedback in Step 2.
I missed adding the update to the single file request button. It should be ok now. |
@sekmiller @djbrooke approved, but it says Meging is blocked once changes are approved. Does @pdurbin need to do the actual (re) approval? I do see an option to "dismiss review" and could try that to see if that clears it. |
@scolapasta yes, it's fine to dismiss the review in this case. |
@pdurbin is out and I (re0 reviewed in his place
What this PR does / why we need it: Adds feedback to the user when they request access to a restricted file.
Which issue(s) this PR closes:
Closes #7469 People requesting access to a file need visible feedback when a request is sent
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: