Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8506 powered by footer #8507

Merged
merged 3 commits into from
Mar 23, 2022
Merged

8506 powered by footer #8507

merged 3 commits into from
Mar 23, 2022

Conversation

ErykKul
Copy link
Collaborator

@ErykKul ErykKul commented Mar 18, 2022

What this PR does / why we need it:
Dataverse footer with "powered by dataverse" logo gets rendered at relative position iso absolute by default. This happens with overloaded custom footer with default style block and on pages that do not fit on screen. See the linked issue for more detail.

Which issue(s) this PR closes:

closes #8506

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErykKul thanks for the pull request! I left some questions about footer vs. dvfooter.

src/main/webapp/resources/css/structure.css Show resolved Hide resolved
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good fix to me. It could always be refactored later, if necessary. Approved.

I ran the code locally and will post my before and after below.

before (note Dataverse logo)

Screen Shot 2022-03-21 at 4 15 31 PM

after (logo in a more reasonable position)

Screen Shot 2022-03-21 at 4 16 03 PM

@pdurbin pdurbin removed their assignment Mar 21, 2022
@kcondon kcondon self-assigned this Mar 21, 2022
@ErykKul
Copy link
Collaborator Author

ErykKul commented Mar 22, 2022

Thank you for approving! I totally agree that there must be a better solution. I do not have the necessary background on css to improve it by myself, I have tried different options and this one works for me.

@kcondon kcondon merged commit 813482c into IQSS:develop Mar 23, 2022
@pdurbin pdurbin added this to the 5.11 milestone Mar 29, 2022
@pdurbin
Copy link
Member

pdurbin commented Mar 31, 2022

@ErykKul just a heads up that we made a further tweak to this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataverse footer with "powered by dataverse" logo gets rendered at relative position iso absolute by default
4 participants