Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5.10 #8511

Merged
merged 696 commits into from
Mar 18, 2022
Merged

Version 5.10 #8511

merged 696 commits into from
Mar 18, 2022

Conversation

kcondon
Copy link
Contributor

@kcondon kcondon commented Mar 18, 2022

What this PR does / why we need it:

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

janvanmansum and others added 30 commits February 4, 2022 21:05
8094 Experimental CI Java 17 Maven Unittest build
…-allow_guestbook_unselect

Fix guestbook clear selection button
explain what info to send for installation support #8198
…dering

Fix 7874-Dataset-template-authors-ordering
…8394

This includes moving/inheriting some project properties from the parent.
pdurbin and others added 24 commits March 16, 2022 15:05
Installer fixes, reflecting the new pom file structure #8494
Fix broken links under "Best Practices" (nav bar) in guides, sync up with dataverse.org
remove reference to closed issue #8496
…/8503-make_iconURL_optional

IQSS/8503 make icon url optional
fix LicensesIT and add to list of tests, fix output of "set license active" API #8501
Updating version to v5.10
Update version to v5.10
Update to v5.10
@kcondon kcondon self-assigned this Mar 18, 2022
@kcondon kcondon merged commit a57ce53 into master Mar 18, 2022
@@ -80,6 +80,11 @@ echo "Set the default facets for Root"
curl -s -X POST -H "Content-type:application/json" -d "[\"authorName\",\"subject\",\"keywordValue\",\"dateOfDeposit\"]" $SERVER/dataverses/:root/facets/?key=$adminKey

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

@@ -52,7 +52,7 @@ echo "Ensuring Unix user '$SOLR_USER' exists"
useradd $SOLR_USER || :
DOWNLOAD_DIR='/dataverse/downloads'
PAYARA_ZIP="$DOWNLOAD_DIR/payara-5.2021.5.zip"
SOLR_TGZ="$DOWNLOAD_DIR/solr-8.8.1.tgz"
SOLR_TGZ="$DOWNLOAD_DIR/solr-8.11.1.tgz"
if [ ! -f $PAYARA_ZIP ] || [ ! -f $SOLR_TGZ ]; then
echo "Couldn't find $PAYARA_ZIP or $SOLR_TGZ! Running download script...."
cd $DOWNLOAD_DIR && ./download.sh && cd

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
Use 'cd ... || exit' or 'cd ... || return' in case cd fails. SC2164

@@ -9,11 +9,11 @@ if [ ! -e dv/deps/payara-5.2021.5.zip ]; then
wget https://s3-eu-west-1.amazonaws.com/payara.fish/Payara+Downloads/5.2021.5/payara-5.2021.5.zip -O dv/deps/payara-5.2021.5.zip
fi

if [ ! -e dv/deps/solr-8.8.1dv.tgz ]; then
if [ ! -e dv/deps/solr-8.11.1dv.tgz ]; then
echo "solr dependency prep"
# schema changes *should* be the only ones...
cd dv/deps/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
Use 'cd ... || exit' or 'cd ... || return' in case cd fails. SC2164

private String fileChecksumValue;
private String dataverseAlias;
private String dataverseParentAlias;
private static final Logger logger = Logger.getLogger(SolrSearchResult.class.getCanonicalName());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
File contains tab characters (this is the first instance).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 18.864% when pulling 27a733f on develop into fb24c87 on master.

@pdurbin pdurbin added this to the 5.10 milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.