Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8623 solr index vocab #8624

Merged
merged 6 commits into from
May 5, 2022
Merged

8623 solr index vocab #8624

merged 6 commits into from
May 5, 2022

Conversation

ErykKul
Copy link
Collaborator

@ErykKul ErykKul commented Apr 20, 2022

Suggestions on how to test this:
Do not configure matadata languages in settings and reindex in solr. Controlled vocabulary fields are no longer searchable by search name, only facetable name (with suffix _s or _ss) is indexed.

Is there a release notes update needed for this change?:
No

@coveralls
Copy link

coveralls commented Apr 20, 2022

Coverage Status

Coverage increased (+0.3%) to 19.239% when pulling be14f53 on ErykKul:8623_solr_index_vocab into 92a14a8 on IQSS:develop.

@ErykKul
Copy link
Collaborator Author

ErykKul commented Apr 22, 2022

#8435 is where this problem originates from.

Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please note that dev is already on solr 8.11.1 so you'll need to update your branch from dev before it can be evaluated by qa. thanks!

@sekmiller sekmiller assigned ErykKul and unassigned sekmiller May 5, 2022
@ErykKul
Copy link
Collaborator Author

ErykKul commented May 5, 2022

@sekmiller I have merged the dev branch into this branch, but Jenkins build still fails. I cannot see why (page times out when I try to access it). Any idea?

@pdurbin
Copy link
Member

pdurbin commented May 5, 2022

@ErykKul here's the error:

testForceReplaceAndUpdate – edu.harvard.iq.dataverse.api.FilesIT
junit.framework.AssertionFailedError: expected:<200> but was:<500>
at edu.harvard.iq.dataverse.api.FilesIT.testForceReplaceAndUpdate(FilesIT.java:668)

I don't think this is anything to worry about though. I just added another comment to the issue below and reopened it:

@kcondon kcondon assigned kcondon and unassigned ErykKul May 5, 2022
@kcondon kcondon merged commit df0853a into IQSS:develop May 5, 2022
@pdurbin pdurbin added this to the 5.11 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment