License info is now also shown in submit for review popup #8691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErykKul
changed the title
ErykKul
changed the title
pdurbin
approved these changes
May 12, 2022
There was a problem hiding this comment.
Looks good to me. I ran the code and will add some screenshots below.
I updated the docs in the user guide to mention the popup.
I also added a release note snippet.
I tested with custom terms. I would suggest testing licenses as well but from what I can tell the xhtml was unchanged and simply moved into a fragment.
Publish popup (unchanged in this PR)
Submit for Review popup (develop/before)
Submit for Review popup (this PR/after)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We show a warning about the license in the submit for review popup, but not the license itself, like we do in the publish popup.
Which issue(s) this PR closes: