Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDCC/8605-add-archival-status-support #8696
GDCC/8605-add-archival-status-support #8696
Changes from 24 commits
de62791
8c82c61
b354bc3
9c9ac65
221ca0b
8902d9a
a37922b
cefa12c
e1c62af
d2bf93c
ae1c97c
d3a7b04
5295bcd
9223e7d
f5396d8
986f9ff
8750e62
5d617f0
8fcb59c
d2d817e
6a70d42
e498417
8a99685
7362e1c
7410c5b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this merge method doesn't already exist on DatasetVersionServiceBean.java. It is because most changes to versions happen through commands? It is because once a version is published there's no need to go back and change the version (except for deaccessioning, I guess, which is a command)? I don't think it's bad to add this method but I wonder why we're only adding it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - I think everything uses a Command of some sort. I was also surprised that it didn't exist as the dataset service has a merge() and the file service has several methods that don't do much more than a merge.