Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc documentation updates #8871

Closed
wants to merge 58 commits into from
Closed

Misc documentation updates #8871

wants to merge 58 commits into from

Conversation

kuhlaid
Copy link
Contributor

@kuhlaid kuhlaid commented Jul 29, 2022

This PR resolves issue #8869

Fixing broken link to Sphinx
Adding style to highlight current page in the menu
Switching @context from a link to inline literal since this text should not link to anything
Updating Maven to 3.8.6 since 3.8.5 is no longer hosted under https://downloads.apache.org/maven/maven-3
Trying to fix Maven path which is not being set
Trying to set Maven path using current directory
Trying to set Maven path
Trying to set Maven Path
Trying to install make
Trying to install make
OpenJdk not in expected directory
Make install
Fix grammar
Simplifying and removing extraneous code
Trying to correct the make directory
Fixing the path to the java install
Trying to fix Maven install
Adding Maven download message
Trying to fix Maven install and download
Moving Maven download
Adding Maven download
Trying different Maven install approach
removing maven download
Test removing the 0prep_deps.sh script
Auto install Maven
Removing hard-coded Solr directory
Trying to add an environment variable for Solr
Removing Solr env var
Adding Solr env var
Removing Solr env variable
Hard-coding Solr path
Not able to pull Solr using apt-get
Trying different Solr approach
@pdurbin
Copy link
Member

pdurbin commented Aug 2, 2022

@kuhlaid 42 commits! You're on a roll! 😄

You seem to be going beyond the scope of #8869.

If possible, can you make smaller pull requests with less scope.

Also, if you ever want to chat, please feel free to pop in https://chat.dataverse.org ! I'd love to hear about where you're going. Thanks for contributing to Dataverse!

Adding back Solr since it cannot be installed via a package manager
Adding back the initial prep
Adding back old Solr handler
Trying to install payara via Yum
Removing payara install
Install testing
Auto install Maven
Reverting back to original
Reverting back
Reverting back
Reverting back
Reverting back
Trying to add Maven and Make
Trying to fix Maven and Make install
Auto install Maven
Need to change to the installer directory
@kuhlaid
Copy link
Contributor Author

kuhlaid commented Aug 2, 2022

Dang it, sorry. I didn't realize the other changes I'm testing were getting pulled into this issue. I'm testing a Docker build separately. Let me see if I can move the files I meant to include in this issue under a separate branch.

@kuhlaid
Copy link
Contributor Author

kuhlaid commented Aug 2, 2022

I submitted a clean PR at #8885 to replace this one that uses a separate branch. I am going to close this PR. - thank you

@kuhlaid kuhlaid closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants