Gdcc/Signposting #8981
Merged
Gdcc/Signposting #8981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* uses external js * adding signposting configuration setting * signposting poc from eko * error fix * move the signposting location in code * Signposting with MicroSettings cleanup v1 xhtml revert to vanilla * clean up * bug fix and add default file type; TODO: Bug on the baseurl (empty string) * hide type when do not use default * set default when no config is set for signposting * modification according to reviews * move long json string from code to bunddle * allow empty config on the level 2 profile Co-authored-by: Kevin Condon <kcondon@hmdc.harvard.edu> Co-authored-by: ekoi <eko.indarto@dans.knaw.nl>
5 tasks
|
Issues found:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This is an update of/replacement for #8424. The original author was unable to continue development to address review comments.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
This PR does not change any human readable part of Dataverse.
curl -I http://linkto.dataverse/dataset to see the signposting L1 header
Link to L2 linkset can be found in L1 header and can be directly viewed in browser
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: release note
Additional documentation:
new discoverability page in admin guide