Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to 5.12 #9004

Merged
merged 1 commit into from
Oct 4, 2022
Merged

bump version to 5.12 #9004

merged 1 commit into from
Oct 4, 2022

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Sep 29, 2022

What this PR does / why we need it:

Bumps the version to 5.12.

Which issue(s) this PR closes:

Closes #8980

Special notes for your reviewer:

None.

Suggestions on how to test this:

I checked these already but:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

No.

Additional documentation:

None.

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the same changes as for 5.11.1

@pdurbin
Copy link
Member Author

pdurbin commented Sep 29, 2022

At https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9004/1/consoleFull I'm seeing this:

TASK [dataverse : copy warfile over release] ***********************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Source /tmp/dataverse/target/dataverse-5.11.1.war not found"}

On the Ansible side I think we need a bump like this: gdcc/dataverse-ansible@5f08dc4

I created an issue:

Thank you for any assistance @donsizemore ! ❤️

@pdurbin
Copy link
Member Author

pdurbin commented Sep 29, 2022

@donsizemore bumped jenkin.yml for me (thanks!) in gdcc/dataverse-ansible@c382f03

I re-ran the job and it's passing now: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9004/2/testReport/

@pdurbin
Copy link
Member Author

pdurbin commented Sep 29, 2022

For next time this is my suggested recipe (I think):

  • ensure develop is passing
  • bump jenkins.yml in Ansible
  • create PR to bump Dataverse, ensure tests pass
  • review and merge PR to bump Dataverse
  • ensure develop is passing
  • merge develop to master, ensure tests pass
  • make release, upload artifacts
  • bump main.yml, etc. in Ansible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump version for 5.12
4 participants