Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to example JSON dataset in API docs #9170

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

vera
Copy link
Contributor

@vera vera commented Nov 17, 2022

What this PR does / why we need it:

I noticed that this link text on https://guides.dataverse.org/en/latest/api/native-api.html#create-dataset-command is not correct.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@pdurbin
Copy link
Member

pdurbin commented Nov 18, 2022

I just previewed this at https://guides.dataverse.org/en/latest/api/native-api.html#create-a-dataset-in-a-dataverse-collection and it look great! It says...

(dataset-finch1_fr.json is a variant of this file that includes setting the metadata language (see :MetadataLanguages) to French (fr).

This is much better than what we have at https://guides.dataverse.org/en/5.12.1/api/native-api.html#create-a-dataset-in-a-dataverse-collection which says.

(dataset-create-new-all-default-fields.json is a variant of this file that includes setting the metadata language (see :MetadataLanguages) to French (fr).

Merging! Thanks, @vera!

@pdurbin pdurbin merged commit 11e7505 into IQSS:develop Nov 18, 2022
@pdurbin pdurbin added this to the 5.13 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants