-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8944 - Extend 'metadatablocks/{block_id}' endpoint JSON output #9213
Conversation
With toArray().toString() we were getting something like this: [Ljava.lang.Object;@76d0a290
@pdurbin I removed the sizing for this. Let's talk during the standup. |
@mreekie this is a one to one replacement. I carefully copied everything over. Yes, let's discuss! |
@JR-1991 I went ahead and added some docs and a release note. Please take a look: ae83c27 add docs #8944 You can preview the doc changes here:
I think this is ready for QA but at standup I plan on explaining that we could do a bit more work:
We could also defer this work, of course. |
@pdurbin thanks for adding the docs and release notes! From my side everything looks fine :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new API test is passing (as are all other API tests): https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9213/2/testReport/edu.harvard.iq.dataverse.api/MetadataBlocksIT/testGetCitationBlock/
Discussed at standup. Everyone seems ok with moving this to QA, especially because we'd probably need to do the extra work (supporting non-English languages) ourselves because the branch is in the IQSS repo and we're not sure if @JR-1991 can quickly add this. We'll wait until someone asks for it. Maybe @JayanthyChengan will save us again. 😅
Approved. Moving to QA.
This is a continuation of PR #9091 due to a change of the branch name.
What this PR does / why we need it:
This PR extends the API endpoint
/api/metadatablocks/{block_id}
to include the following fields:multiple
: Whether or not multiple instances of this field can existisControlledVocabulary
: Whether or not this field has a controlled vocabulary. Important to derive thetypeClass
later oncontrolledVocabularyValues
- If a vocabulary is given, includes all possible values.With this extension it is possible to build compatible Dataverse JSON files for upload and download from any installation without having access to the TSV files. EasyDataverse would greatly benefit from this and allow users to "connect" to a Dataverse installation without the need of generating specific code.
Which issue(s) this PR closes:
Special notes for your reviewer:
None
Suggestions on how to test this:
Add or extend a fixture to test if the new fields are given upon execution.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
The API endpoint
/api/metadatablocks/{block_id}
has been extended to include the following fields:multiple
: Whether or not multiple instances of this field can existisControlledVocabulary
: Whether or not this field has a controlled vocabulary.controlledVocabularyValues
- If a vocabulary is given, includes all possible values.Additional documentation:
None