Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9224 - revert workflow metadata block in Solr schema #9225

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

poikilotherm
Copy link
Contributor

@poikilotherm poikilotherm commented Dec 13, 2022

What this PR does / why we need it:

As discussed for #7877, we don't want experimental metadata block fields in the out-of-the-box schema.xml, but introduced them for the workflow schema in #8812.

Which issue(s) this PR closes:

Closes #9224

Special notes for your reviewer:
Please review the docs changes to give people a heads up.

See https://dataverse-guide--9225.org.readthedocs.build/en/9225/user/appendix.html#experimental-metadata for preview.

Suggestions on how to test this:
Delete the fields, reindex, you're done.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.

Is there a release notes update needed for this change?:
🔋 included

Additional documentation:
🔋 included

@poikilotherm poikilotherm added HERMES related to @hermes-hmc work on Dataverse code HDC Harvard Data Commons HDC: 2 Harvard Data Commons Obj. 2 labels Dec 13, 2022
@poikilotherm poikilotherm marked this pull request as ready for review December 13, 2022 19:52
@poikilotherm poikilotherm mentioned this pull request Dec 13, 2022
3 tasks
@pdurbin pdurbin added the Size: 3 A percentage of a sprint. 2.1 hours. label Dec 13, 2022
@pdurbin
Copy link
Member

pdurbin commented Dec 13, 2022

Looks great. I made a tiny suggestion. Otherwise this is ready for QA. Gave it a 3 (the smallest possible) as a size.

Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
@poikilotherm
Copy link
Contributor Author

Looks great. I made a tiny suggestion. Otherwise this is ready for QA. Gave it a 3 (the smallest possible) as a size.

@pdurbin I think you need to approve the change or @kcondon will not be able to merge.

@pdurbin
Copy link
Member

pdurbin commented Dec 21, 2022

@poikilotherm right, merging is blocked until someone clicks "approve" in a review.

But first things first. This PR hasn't been prioritized yet. It's currently at the bottom of the HERMES column at https://github.com/orgs/IQSS/projects/34/views/1 . The goal is the "1️⃣ ▶ORDERED BACKLOG (Stefano)" column and eventually into a sprint at https://github.com/orgs/IQSS/projects/2 . I hope that makes sense. I think we should document this as part of this issue:

@mreekie
Copy link

mreekie commented Feb 1, 2023

backlog grooming

  • @poikilotherm I got here by way of 7844 codemeta schema #7877
  • I just want to reaffirm what Phil said about the priority. When Stefano chooses what to pull into an upcoming sprint, he looks for the items at the top of any column first.
  • I saw today that this is at the bottom of your list and figured I'd ping to double check
  • If it's your intent that this be at the bottom of your priority then no action is needed.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

@kcondon kcondon self-assigned this Feb 6, 2023
@kcondon kcondon merged commit 0789326 into IQSS:develop Feb 6, 2023
@pdurbin pdurbin added this to the 5.13 milestone Feb 11, 2023
@pdurbin
Copy link
Member

pdurbin commented Feb 15, 2023

@poikilotherm poikilotherm deleted the 9224-revert-workflow-solr-schema branch February 15, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HDC Harvard Data Commons HDC: 2 Harvard Data Commons Obj. 2 HERMES related to @hermes-hmc work on Dataverse code Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Revert adding workflow metadata block field to Solr Schema
5 participants