-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9224 - revert workflow metadata block in Solr schema #9225
9224 - revert workflow metadata block in Solr schema #9225
Conversation
Looks great. I made a tiny suggestion. Otherwise this is ready for QA. Gave it a 3 (the smallest possible) as a size. |
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
@poikilotherm right, merging is blocked until someone clicks "approve" in a review. But first things first. This PR hasn't been prioritized yet. It's currently at the bottom of the HERMES column at https://github.com/orgs/IQSS/projects/34/views/1 . The goal is the "1️⃣ ▶ORDERED BACKLOG (Stefano)" column and eventually into a sprint at https://github.com/orgs/IQSS/projects/2 . I hope that makes sense. I think we should document this as part of this issue: |
backlog grooming
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me.
What this PR does / why we need it:
As discussed for #7877, we don't want experimental metadata block fields in the out-of-the-box
schema.xml
, but introduced them for the workflow schema in #8812.Which issue(s) this PR closes:
Closes #9224
Special notes for your reviewer:
Please review the docs changes to give people a heads up.
See https://dataverse-guide--9225.org.readthedocs.build/en/9225/user/appendix.html#experimental-metadata for preview.
Suggestions on how to test this:
Delete the fields, reindex, you're done.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.
Is there a release notes update needed for this change?:
🔋 included
Additional documentation:
🔋 included