Fix for the broken "earliest date" (#9309) #9316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A trivial fix for the embarrassing OAI server bug in 12.1
Which issue(s) this PR closes:
Closes #9309
Special notes for your reviewer:
Suggestions on how to test this:
(I have synced with develop and resolved the merge conflict; it is indeed ready for QA - but please see the note below)
One important note: the PR #9310, that has already been merged, provided a parallel fix for the worst manifestation of this bug, the part where incremental harvest requests were being rejected as described in the issue. This means you can no longer test that symptoms on develop branch in its current form (although it's still present in prod. and demo). (to clarify: it "provided a parallel fix" because the problem had also been fixed in the XOAI library, and in that PR we switched to the latest version of it).
We still need this PR, because it fixes the remaining part of the bug. Namely, the "earliest record in the repository" time stamp is still advertised incorrectly, and this can still be observed in develop. For example, looking at
https://dataverse-internal.iq.harvard.edu/oai?verb=Identify
, the earliest record's date is shown to be the "epoch", i.e.1970-01-01
:(and in prod. and demo, it is still being reported as the time of the last Payara restart☹️ )
WIth the fix in this branch, it will change to the actual timestamp on the earliest record in the OAI sets on the server.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: