-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase "universe" in variablemetadata table from varchar 255 to text #9741
increase "universe" in variablemetadata table from varchar 255 to text #9741
Conversation
Update from IQSS
Update from develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Should the VariableMetadata class have a @column(columnDefinition="TEXT") annotation for universe as well? (Presumably that's not necessary but would make the code clearer/match other fields.)
FWIW: The test failure is for testMoveLinkedDataset – edu.harvard.iq.dataverse.api.MoveIT and is presumably related to test issues we've been having. Can't really be related to this PR. |
Also, I hope you don't mind but I gave this issue a new title. I'm guessing you don't think it's worth adding a release note snippet but please feel free to add one if you like. |
What this PR does / why we need it: It increases field universe in variablemetadata table from varchar 255 to text.
Which issue(s) this PR closes: #9728
Closes #9728
Special notes for your reviewer:
Suggestions on how to test this: use data curation tool to insert in "universe" field string bigger than 255 and save to dataverse. Open Data Curation or Data Explorer to see that field was saved.