Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase "universe" in variablemetadata table from varchar 255 to text #9741

Merged
merged 16 commits into from
Jan 19, 2024

Conversation

lubitchv
Copy link
Contributor

What this PR does / why we need it: It increases field universe in variablemetadata table from varchar 255 to text.

Which issue(s) this PR closes: #9728

Closes #9728

Special notes for your reviewer:

Suggestions on how to test this: use data curation tool to insert in "universe" field string bigger than 255 and save to dataverse. Open Data Curation or Data Explorer to see that field was saved.

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should the VariableMetadata class have a @column(columnDefinition="TEXT") annotation for universe as well? (Presumably that's not necessary but would make the code clearer/match other fields.)

@qqmyers
Copy link
Member

qqmyers commented Jul 27, 2023

FWIW: The test failure is for testMoveLinkedDataset – edu.harvard.iq.dataverse.api.MoveIT and is presumably related to test issues we've been having. Can't really be related to this PR.

@pdurbin pdurbin changed the title 9728 universe variablemetadata increase "universe" in variablemetadata table from varchar 255 to text Jul 27, 2023
@pdurbin
Copy link
Member

pdurbin commented Jul 28, 2023

Yes, @lubitchv if you merge the latest from develop, I assume you'll pick up #9703 which should fix the MoveIT test.

@pdurbin
Copy link
Member

pdurbin commented Jul 28, 2023

Also, I hope you don't mind but I gave this issue a new title.

I'm guessing you don't think it's worth adding a release note snippet but please feel free to add one if you like.

@pdurbin pdurbin added Feature: Metadata Size: 3 A percentage of a sprint. 2.1 hours. labels Jul 28, 2023
@lubitchv
Copy link
Contributor Author

Yes, @lubitchv if you merge the latest from develop, I assume you'll pick up #9703 which should fix the MoveIT test.

It is already should be there and if there are still integration errors it did not fix it.

@stevenwinship stevenwinship self-assigned this Jan 19, 2024
@stevenwinship stevenwinship merged commit 1f24f7c into IQSS:develop Jan 19, 2024
@stevenwinship stevenwinship removed their assignment Jan 19, 2024
@pdurbin pdurbin added this to the 6.2 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Metadata Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universe field in variablemetadata table
4 participants