-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9739 - URLValidator now allows two slashes in the path component of the URL #9750
#9739 - URLValidator now allows two slashes in the path component of the URL #9750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. FYI - I did a quick check and UrlValidator is also used to decide whether the forwarding URL for a deaccessioned dataset is OK. I think allowing two slashes there is also OK, but we should be aware that this PR as is will change that as well.
The ec2 instance didn't spin up. I just triggered another run of the API tests: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9750/2/ |
@luddaniel a small release note for this change would ne nice for users, as well. |
@scolapasta release node is added |
What this PR does / why we need it:
URLValidator now allows two slashes in the path component of the URL
Which issue(s) this PR closes:
Closes #9739
Special notes for your reviewer:
From what I see, URLValidator is used to :
As discussed in #9739, a user is able to provide "valid" syntax url that can be "invalid" when used, so allowing two slashes in the path component of the URL seems to not bring any danger.
Suggestions on how to test this:
Example of allowed url : https://archive.softwareheritage.org/swh:1:dir:561bfe6698ca9e58b552b4eb4e56132cac41c6f9;origin=https://github.com/gem-pasteur/macsyfinder;visit=swh:1:snp:1bde3cb370766b10132c4e004c7cb377979928d1;anchor=swh:1:rev:868637fce184865d8e0436338af66a2648e8f6e1
Does this PR introduce a user interface change?
No
Is there a release notes update needed for this change?
No