Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Vagrant (unused) #9839

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Remove Vagrant (unused) #9839

merged 3 commits into from
Aug 29, 2023

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Aug 28, 2023

What this PR does / why we need it:

We agreed to remove Vagrant in Slack the other day: https://iqss.slack.com/archives/C010LA04BCG/p1692040813846129

I gave the community a chance to weigh in ( https://groups.google.com/g/dataverse-community/c/y1_JCWN44II/m/FFjQTkJ4AwAJ ) but no one seems interested in keeping Vagrant.

Having Vagrant around slows us down when we need to update Payara, Java, or Solr. (For the same reason we removed the Perl installer and docker-aio in the Payara 6 upgrade PR: b829ca7 )

Which issue(s) this PR closes:

Special notes for your reviewer:

I did keep/move the Vagrant version of counter-processor-config.yaml because it might be useful. In the guides we recommend that developers use this file for testing on an EC2 instance.

Suggestions on how to test this:

Make sure the API tests pass.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Yes, added.

Additional documentation:

None.

The download.sh script was originally added in 294006e
to support Vagrant in but now that we have removed Vagrant,
it is unnecessary.

We are moving the entire "downloads" directory, including
Stata14TestFile.dta, which isn't used by any test. It was added
in 9e7c40b.
@pdurbin pdurbin added this to the 6.0 milestone Aug 28, 2023
@kcondon kcondon self-assigned this Aug 29, 2023
@kcondon
Copy link
Contributor

kcondon commented Aug 29, 2023

@pdurbin
Copy link
Member Author

pdurbin commented Aug 29, 2023

@kcondon thanks, yeah, unfortunately, we're seeing some flakiness in our test suite. If you compare with #9835 you'll see similar tests failing:

https://jenkins.dataverse.org/blue/organizations/jenkins/IQSS-Dataverse-Develop-PR/detail/PR-9835/2/tests

Screen Shot 2023-08-29 at 4 12 23 PM

I'm 99% sure these are unrelated to Vagrant, which is just a bunch of scripts and docs.

I opened this issue to investigate the failing tests:

@kcondon kcondon merged commit b62b561 into develop Aug 29, 2023
1 check passed
@kcondon kcondon deleted the 9838-rm-vagrant branch August 29, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove Vagrant
3 participants