Remove unused code #9915
Closed
Remove unused code #9915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not check for imports that are covered by `import *`
Removing unused methods made some imports unused
While fixing the merge conflict I removed a used import
|
Merge conflict... this PR is too big, so I will try to split it into more smaller PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove unused imports and remove private methods that are not called. These unused imports and methods were flagged by Sonarlint.
Having fewer methods (some with todos) should help reduce cognitive load. It may make development smoother, since IDEs and other tools have fewer lines of code to consider.
Which issue(s) this PR closes:
Closes #9918
Special notes for your reviewer:
I know, this is a big change. The changes are strictly limited to the imports and unused methods.
Did you see how the test coverage went up? 😉
Suggestions on how to test this:
Run the integration tests; the unit tests already pass.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
https://sonarcloud.io/summary/new_code?id=bencomp_dataverse&branch=unused-code is a comparison of this branch and my fork's develop branch, which shouldn't be far behind the IQSS develop branch.