make configure tools available at the dataset level #9925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
As I mentioned in standup, now that I fixed the icon in 258023e to match the file-level configure tool, this is ready for review. |
|
I'm pulling this back into development because I realized I forgot to add the popup that configure tools have at the file level. Here's how it looks for the Data Curation Tool:
I checked with ICPSR and they said they'd still like the popup, as discussed previously. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
With some help from @sekmiller (thanks!), I was able to make progress on the popup. Here's how it looks:
|
This comment has been minimized.
This comment has been minimized.
sekmiller
reviewed
Sep 29, 2023
sekmiller
reviewed
Sep 29, 2023
sekmiller
requested changes
Sep 29, 2023
|
@sekmiller thanks for catching those! Fixed. |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
sekmiller
requested changes
Oct 2, 2023
sekmiller
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ICPSR is making a tool called TurboCurator. See #9589. Other members of the community have also expressed interest in creating a configure tool at the dataset level.
Which issue(s) this PR closes:
Special notes for your reviewer:
I left a TODO about some potential code consolidation.
Suggestions on how to test this:
Add a configure tool at the dataset level and test it. ExternalToolsIT.java has JSON you can use if you like.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes and I'm using a gear/cog ⚙️ to match configure tools at the file level:
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
Docs have been updated: