…#7424

…#7424

We only default to no authentication. We still require people to
configure an SMTP host, only in containers we do default to "smtp"
as a hostname for that (see our compose file).

Username/password cannot have a default and all other special settings
should not be done here. These are highly setup specific.

IQSS#7424

As a hack to work around testcontainers/testcontainers-java#970,
we add these fake, empty classes. Copied from Spring project.

See also: testcontainers/testcontainers-java#970

…S#7424

Necessary to add some integration testing, verifying sending mails
actually should work.

…sage IQSS#7424

If not excluded, the very old Javamail 1.4 spec is being used during
local testing, obviously incompatible with Jakarta EE Mail definition.

Exclusion is the only way around this, as we cannot possibly change the
upstream dependencies.

…ver IQSS#7424

…QSS#7424

…7424

Besides adding the JVM option, the logic to receive the setting in MailServiceBean has changed.
The method signature is now returning an optional to enforce the optional nature of the setting.
This replaces the "null" contract from before and requires more changes to code using the lookup.

…dress IQSS#7424

As we changed the lookup function to use Optional<InternetAddress> to enforce the optional
nature of the setting, we now have to change the code using the function.

To ease looking up the (also optional) setting of a support team mail address,
the mail service is extended with another lookup function. This is intended
to replace many manual, error prone lookups, also streamlining the fall-through
behavior when not set, etc.

…#7424

As we now have proper functions to lookup the mail addresses, replace manual lookup and parsing with them.

Document in code how to replace usages, too. (There aren't any,
but in case someone is adding it again in the future, it helps to
have docs)

As we replaced the lookups and parsing with a streamlined version of it all
in MailServiceBean, we don't need this helper function anymore.

… as expected IQSS#7424

…sary stub exceptions

- With JavaMail 1.6+, we have support for UTF-8 mail addresses and don't need to parse these ourselves
- Remove some C-style coding and duplications
- Make logging eat less cycles
- Add missing Javadocs

- Make support configurable using new setting, defaulting to true
  (most MTAs today should support SMTPUTF8)
- If need be and an admin disables the support, make email validator
  deny UTF-8 chars (otherwise no mails could be sent!)
- Add logging message to send method to give hint about necessary
  UTF-8 support everywhere in the chain
- Add (extensible) integration test for MailServiceBean to check
  sending mails actually works

…anged value during tests

Also switch to safer lookup via codepoint comparison to 7bit = chars < 128 in favor over encoder

Mail notification are optional (mostly to avoid setting up mail
services in dev envs). Do not enforce MTA host config and do not
pester logs about missing configuration.

Using @resource on the field triggers deployments to fail if the resource is not provided by the app server.
Using a programmatic lookup, we can catch and ignore the exception.

Without this change, the javamail maps would not be included in the artifact and trigger error messages in the logs about them being missed.

The error message will still be present as long as payara/Payara#6254 is
not fixed, released and we updated to a newer version of Payara.

During the deployment of Dataverse we check for conditions of the mail system that might not be done as people intend to use it.
We'll only issue warnings in the log messages, nothing critical here.

Also fix minor linting with visibility of test methods.

Adding an integration test with self-signed certificates to enable verification SMTP over SSL works.

The DB settings names are not compliant with usual Java enum name rules. Ignoring to avoid unnecessary clutter, hiding more important problems.

…tion

The section about securing your installation was missing hints about how to store and access passwords in a safe manner.

Now having a single place to reference from everywhere makes the config bits for passwords much more readable, as we do not need to provide as many examples.

Instead of setting a DB setting, we now simply apply system properties.
Also, aligned with the way the "from" address is now bound to be the system mail address, this commit removes this subtle difference in the installer as well.

…7424

…ress

Thanks @pdurbin!

Co-authored-by: Philip Durbin <philipdurbin@gmail.com>

…4-maildefinition-ng

The setting is already covered by the "host" property string in MailSessionProducer.

As Payara 6.2023.7 still suffers from the MPCONFIG bug where a profiled setting is not easy to override, lets just remove the default for the container profile and make people add it even for containers.

In case people want to debug Jakarta Mail, they activate dataverse.mail.debug. Let's hook into that and add more verbose output from the session producer, too. That way people can make sure everything is set up as they wish.

Also add notes about common ports in use.

…4-maildefinition-ng

We need to downgrade to 0.43.4 again because of this regression: fabric8io/docker-maven-plugin#1756
Once they release a new version, try again.

…section