Fix code coverage reports after introducing QueryDSL #9991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classed generated by QueryDSL are included in the JaCoCo report because of not using an `@Generated` annotation that is of retention scope "runtime" or "class". This commit moves the APT dependency for QueryDSL to the Maven compiler plugin configuration and annotation processor, which makes it configurable. Switching the annotation to be used with QueryDSL generated classes fixes the code coverage reporting problem. See also: querydsl/querydsl#3131 (comment) See also: https://querydsl.com/static/querydsl/latest/reference/html/ch03s03.html
|
Without the changes here I definitely see the QueryDSL generated classes in the HTML report:
|
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
|
Superseded by #10041 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Coveralls report is broken because JaCoCo's XML report file contains generated source files (and cannot be made to exclude them). The Coveralls Maven Plugin does not skip these classes and breaks of trying to read nonexisting source files.
Which issue(s) this PR closes:
Closes #9990
Special notes for your reviewer:
Suggestions on how to test this:
None
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope
Is there a release notes update needed for this change?:
Nope
Additional documentation:
None