Extended 511 #551
Merged
Extended 511 #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by various methods, including those found in rules_40xx.py, to ease maintenance
…ion protocol types
Since the DOI regex works now there are 2 fewer warnings. Previously it was warning about valid DOIs.
i_df and investigation_df are not a DataFrame as indicated in parameter typing or as the name would suggest. It's actually a dictionary of DataFrames and lists of DataFrames. I have renamed them to reflect this.
There were 2 tests that needed to be changed to match the new naming.
This was referenced Mar 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@terazus @ptth222
worked in parallel to incorporate all PRs by @ptth222 and reviews by @terazus
uncovered a few more 'features' while testing the ISA serializations and roundtrip (tab/tab, json/json, tab/json).
All seems now addressed and running isa-cookbook/content/notebooks/isa-api-programmatic-BH2023-multiomics-isa.ipynb now works as expected.
Did not get the latest changes by @ptth222 though.