-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/141-tests-for-volunteer #145
Conversation
…nto feature/141-tests-for-volunteer
…ISPP-G5/NexONG_Backend into feature/141-tests-for-volunteer
…nto feature/141-tests-for-volunteer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that you are testing admin permissions and not volunteer ones. To test the volunteer actor you should test the following:
- Register as a volunteer, first create a
User
instance, then aVolunteer
one, and finally link that volunteer to the user via the FK in user. Delete and edit your own profile. - Sign up for events.
- Sign up for classes.
You should also test that as a volunteer you cannot do certain things. For example, edit a class.
Tip: read requirements document for inspiration.
Create the unit tests for the main features of the volunteer user. Also, check that all the validations are correct, and the user can write where is supposed to write, and cannot where is not. This is the task i have done, the main features of a volunteer are the CRUD, so for the test of the main features, we need to test the CRUD operations of volunteer, that is what i have done |
Check our TL's message in Discord. |
…nto feature/141-tests-for-volunteer
…ISPP-G5/NexONG_Backend into feature/141-tests-for-volunteer
…ISPP-G5/NexONG_Backend into feature/141-tests-for-volunteer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much much better :) and I can tell you put effort into this. You test all the functionalities a Volunteer user can do on our platform. However, I have a few requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should check aurora's feedback.
My bad did not see the feedback. I will do it today thanks. |
…nto feature/141-tests-for-volunteer
…ISPP-G5/NexONG_Backend into feature/141-tests-for-volunteer
…ISPP-G5/NexONG_Backend into feature/141-tests-for-volunteer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are well done now 👍. But I have a question about the change you made in eventSerializer.py.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your response!
Added test for volunteer modelviewset.
To probe it just have to use the command: python manage.py test