Feature/171-fix-email #177
Conversation
There was a problem hiding this comment.
Thank you for your implementation. However, there seems to be a problem. In the PR description, you say that only the last two lines of the email are translated, but this is the email I get:
You say you made a template, but in the commit called "bug" you removed it. I saw that you can customize the email template in this tutorial. From 1:10:00 to 1:19:30. I know it's in Hindi 🤣, but I think it's "followable".
Also, about the second point in issue #171. It says Write in the HTML of the activation the next steps after activating the account (URL to the frontend login using username and password...). What it means is that in the HTML page, the mail took you before (the one that said that your account had been activated), you were supposed to write what was the next step for the user to access their new account. For example, it should say something like: Tu cuenta ha sido activada. Para usarla vaya a (link página frontend) y loguese con su correo y contraseña. However, I think your approach is actually better 👍.
|
Since I didn't get the whole email translated, I decided to delete the changes I made since some of them were made in the settings.py. As well as the template that as I could not use it I also ended up deleting it. I will take a look at the video and apply the feedback for the activation screen. |
…nto feature/171-fix-email
In this pr we have made the redirection to the frontend login when you access the activation email link.
For the translation of the email sent automatically by djoser, I have made changes, such as creating my own template to translate the message but only the last 2 lines of the email have been translated. I would like to know if you can think of something about how to do it (I have not found it) or if we leave that part of the issue(#171 ), since the gmail itself comes with a built-in translation tool.
I await your comments.