Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/142 tests for educator #179

Merged
merged 17 commits into from
Apr 20, 2024
Merged

Feature/142 tests for educator #179

merged 17 commits into from
Apr 20, 2024

Conversation

JuanluRM
Copy link
Contributor

Educator tests for all clases that educator can interact with.
You can try them with py manage.py test

@JuanluRM JuanluRM added the enhancement New feature or request label Apr 16, 2024
@JuanluRM JuanluRM added this to the Sprint 3 milestone Apr 16, 2024
@JuanluRM JuanluRM self-assigned this Apr 16, 2024
@JuanluRM JuanluRM linked an issue Apr 16, 2024 that may be closed by this pull request
Tests for educator #142
Closed
manortbla
manortbla previously approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@manortbla manortbla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your time. All actions on Lesson, Student, CenterExit and Evaluation are well checked. Well done.

@JuanluRM JuanluRM requested a review from manortbla April 18, 2024 23:14
manortbla
manortbla previously approved these changes Apr 19, 2024
View reviewed changes
@JuanluRM JuanluRM requested a review from manortbla April 20, 2024 11:25
pabpercab1
pabpercab1 approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@pabpercab1 pabpercab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests cover all the important business logic of Educators, including Lessons, Evaluations, etc. Great work on this.

@pabpercab1 pabpercab1 merged commit 0f7be7d into develop Apr 20, 2024
7 checks passed
@pabpercab1 pabpercab1 deleted the feature/142-tests-for-educator branch April 20, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabpercab1 pabpercab1 pabpercab1 approved these changes

@manortbla manortbla manortbla approved these changes

Assignees

@JuanluRM JuanluRM

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 3
Development

Successfully merging this pull request may close these issues.

Tests for educator
3 participants
@JuanluRM @manortbla @pabpercab1