Fix/144-main-page-information #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartaInes
reviewed
Mar 26, 2024
|
Thanks for the feedback, Marta. I was wondering myself about the placement and whether it was better below, or on the right. I will do as requested as soon as I can.
…________________________________
From: MartaInes ***@***.***>
Sent: 26 March 2024 16:59
To: ISPP-G5/NexONG_Frontend ***@***.***>
Cc: SAMUEL LUIS RODRIGUEZ MANESS ***@***.***>; Assign ***@***.***>
Subject: Re: [ISPP-G5/NexONG_Frontend] Fix/144-main-page-information (PR #156)
@MartaInes commented on this pull request.
The buttons seem to be working just fine, but maybe the location could be improved. Maybe the "Leer más" one could be placed below the text, following the style of the others.
—
Reply to this email directly, view it on GitHub<#156 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AROWHP4CAEL3WBLZRQ2ZKGDY2GEL3AVCNFSM6AAAAABFJFNFKSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRQHEYDIOBVGA>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
claugp06
approved these changes
Mar 27, 2024
fracalrod3
approved these changes
Mar 27, 2024
|
I made a small change following Marta's comment. I believe it looks a lot better now. |
claugp06
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the main page (localhost:3000/) I noticed a button leading to the 'Conócenos' page and the 'Historia' page were missing.
As far as I could tell, the description and the rest of the links are implemented and working.