Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/120 admin volunteers docs #182

Merged
merged 17 commits into from
Apr 12, 2024
Merged

Conversation

ivaramlar
Copy link
Contributor

Now it is possible to download a file, to do it, it is necessary to follow the next steps:
1- Create a new volunteer object in the API with status="PENDIENTE" and correct files.
2- Create a new user with type volunteer and establish the new volunteer created before.
3- Initiate the app and login like an admin, go to volunteer request and click on the bottom descargar.

Only the enrollment document is going to be downloaded because I haven't been able to implement the functionality to download several of them. I have been more of an hour fighting ChatGPT, but it doesn't help at all.

@ivaramlar ivaramlar linked an issue Apr 5, 2024 that may be closed by this pull request
@claugp06 claugp06 self-requested a review April 6, 2024 07:54
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the steps and created a volunteer in the Api but it does not appear in "Solicitudes" maybe I am doing somenthing wrong but I cannot be sure

@claugp06 claugp06 added the enhancement New feature or request label Apr 6, 2024
@claugp06 claugp06 added this to the Sprint 3 milestone Apr 6, 2024
@ivaramlar
Copy link
Contributor Author

I followed the steps and created a volunteer in the Api but it does not appear in "Solicitudes" maybe I am doing somenthing wrong but I cannot be sure

Have you created a user and established the volunteer id ? I have done that and i can see the new user in request.

@claugp06 claugp06 self-requested a review April 6, 2024 09:42
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad i did not put the Id sorry. I have a few things to point out.

  • It will be nice if a toast message it shown when a volunteer it is accepted or reject it.
  • As it is said the docs are empty why is that? The docs parts it has been done my the backend already
  • I know you comment it that only you are able to download the enrollment but it should be all the documents download. If you need help , ask the frontend people they might have some idea

Copy link
Contributor

@marnunrey2 marnunrey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it and it works but, as you said, it's only downloading the enrollment document. Have you though of trying that in the descargarDocumento constant try to get every document of the volunteer (check if the volunteer is under 18 to download also the minor authorization and the scanned authorizer id) and with those files create a zip and assign the enlaceDescarga.href and enlaceDescarga.download to the zip created?

@ivaramlar
Copy link
Contributor Author

The issue is going to be done in the week number 10, it needs that the funtionality stay implemented in the back before.

@claugp06
Copy link
Collaborator

claugp06 commented Apr 8, 2024

The issue is going to be done in the week number 10, it needs that the funtionality stay implemented in the back before.

Sounds good, could you have in account the following (becuase you are already working on volunteers and you have been working more over it and have more idea of the code) that volunteers can be edit by the admin

@ivaramlar
Copy link
Contributor Author

Now, it is possible to download a zip with all the files from a volunteer. To do it, it is necessary to follow all the steps that I put in the first comment.

Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the last version of develop of the back and when I press download to check the file I get this error
image

@ivaramlar ivaramlar requested a review from claugp06 April 11, 2024 09:12
@ivaramlar
Copy link
Contributor Author

I have the last version of develop of the back and when I press download to check the file I get this error image

Please follow the instructions, you are trying to download the files from a user loaded from the API instead of a user created by you.

Copy link
Contributor

@marnunrey2 marnunrey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, it works as expected!

Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected nice job. Make sure you resolve the merge conflicts that appear.

@FelixoGudiel
Copy link
Contributor

Please, update this branch

Copy link
Contributor

@FelixoGudiel FelixoGudiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.Good job!

@claugp06 claugp06 merged commit bd2f5ac into develop Apr 12, 2024
1 check passed
@claugp06 claugp06 deleted the feature/120--admin-volunteers-docs branch April 12, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat/120- admin volunteers docs
4 participants