Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/232 meetings #245

Merged
merged 6 commits into from
Apr 27, 2024
Merged

Fix/232 meetings #245

merged 6 commits into from
Apr 27, 2024

Conversation

ivaramlar
Copy link
Contributor

Now, you are able to edit a meeting event in the screen "Eventos", to do it, you need to log in as an admin.

@ivaramlar ivaramlar linked an issue Apr 26, 2024 that may be closed by this pull request
samrodman
samrodman previously approved these changes Apr 26, 2024
Copy link
Contributor

@samrodman samrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well for me, although i don't know if the time can be shown in HH:mm without the seconds. Good job though I will aprove the request to make things smoother.

Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and works but I just to small comments:

  1. The first one is that it does not allows to create a meeting if the selected data is the same as today, is this intent to be like this?. I am just asking because imagine the NGO has to create an emergency meeting for the same day, they could not do it.
  2. Also, when you access to the details of the meeting on the calendar you can see a input called asistentes but all partners are welcome to attent so it should not be shown I think

@ivaramlar ivaramlar requested review from claugp06 and samrodman April 27, 2024 09:17
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working as expected good job with that but instead of having to refresh the page to see that the meetings has been deleted or updated it should be done automatically. I believe this has already be done in other parts of the web page and I think it was done with events

@claugp06 claugp06 added the bug Something isn't working label Apr 27, 2024
@claugp06 claugp06 added this to the PPL milestone Apr 27, 2024
@claugp06 claugp06 self-requested a review April 27, 2024 10:02
@ivaramlar
Copy link
Contributor Author

It is working as expected good job with that but instead of having to refresh the page to see that the meetings has been deleted or updated it should be done automatically. I believe this has already be done in other parts of the web page and I think it was done with events

The feature has been implemented following the feature of edit and delete events. If we implement the option refresh the page automatically, the toast messages are not going to be shown because the refresh not take to count the toast.

@claugp06
Copy link
Collaborator

It is working as expected good job with that but instead of having to refresh the page to see that the meetings has been deleted or updated it should be done automatically. I believe this has already be done in other parts of the web page and I think it was done with events

The feature has been implemented following the feature of edit and delete events. If we implement the option refresh the page automatically, the toast messages are not going to be shown because the refresh not take to count the toast.

Ah I did not know, in that case we just leave it as it is done at the moment

Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having in consideration the comment you made about the toast confirmation messages, I will aprove this pr

Copy link
Contributor

@fracalrod3 fracalrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to be working fine, and considering what's been previously discussed here, it's an overall great job! keep it up!

@fracalrod3 fracalrod3 merged commit ca8884c into develop Apr 27, 2024
1 check passed
@fracalrod3 fracalrod3 deleted the fix/232-meetings branch April 27, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix/232-meetings
4 participants