Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/241 admin lessons #256

Merged
merged 3 commits into from
May 1, 2024
Merged

Fix/241 admin lessons #256

merged 3 commits into from
May 1, 2024

Conversation

samrodman
Copy link
Contributor

The issue that this PR solves, is that now the update of a lesson is done with the PATCH method instead of PUT.
After asking backend to give permission for the operation, it now appears to be working. All you need to do is log in as an admin and I recommend creating a lesson and trying to edit one thing and check that the PATCH request comes through.

If there are any other fixes for lessons this could be a good branch to implement those.

claugp06

This comment was marked as off-topic.

@claugp06 claugp06 self-requested a review April 30, 2024 15:27
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everythings works fine and I think not more changes related with lessons have to be implemented

@claugp06 claugp06 added the bug Something isn't working label Apr 30, 2024
@claugp06 claugp06 added this to the PPL milestone Apr 30, 2024
Copy link
Contributor

@FelixoGudiel FelixoGudiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Good job!

@samrodman samrodman merged commit ae532e6 into develop May 1, 2024
1 check passed
@samrodman samrodman deleted the Fix/241-admin-lessons branch May 1, 2024 16:44
@claugp06 claugp06 linked an issue May 2, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix/241-admin-lesson
3 participants