Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/259-attendence-volunteer #260

Merged
merged 3 commits into from
May 4, 2024
Merged

Fix/259-attendence-volunteer #260

merged 3 commits into from
May 4, 2024

Conversation

manbarjim2
Copy link
Contributor

No description provided.

@manbarjim2 manbarjim2 linked an issue May 3, 2024 that may be closed by this pull request
Fix/259-attendence-volunteer #259
Closed
@manbarjim2 manbarjim2 requested a review from claugp06 May 3, 2024 17:35
@manbarjim2 manbarjim2 self-assigned this May 3, 2024
@manbarjim2 manbarjim2 added the bug Something isn't working label May 3, 2024
@manbarjim2 manbarjim2 added this to the PPL milestone May 3, 2024
@fracalrod3 fracalrod3 self-requested a review May 3, 2024 18:01
claugp06
claugp06 requested changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to be refresh so the events/classes/... I sign up appears

fracalrod3
fracalrod3 requested changes May 3, 2024
View reviewed changes
Copy link
Contributor

@fracalrod3 fracalrod3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried it and you need to refresh the page to see your current events, still a good job overall, a little tweak that'd be all

@manbarjim2 manbarjim2 requested review from claugp06 and fracalrod3 May 4, 2024 10:34
claugp06
claugp06 requested changes May 4, 2024
View reviewed changes
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refresh it is not needed it anymore, good job!.
But I get now this error if I try to delete an event
image

I am using the volunteer with emaill mcast@gmail.com

@manbarjim2 manbarjim2 requested a review from claugp06 May 4, 2024 10:56
claugp06
claugp06 approved these changes May 4, 2024
View reviewed changes
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is working as expected, nice job!

fracalrod3
fracalrod3 approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@fracalrod3 fracalrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's working as intended

@fracalrod3 fracalrod3 merged commit f6e4cd4 into develop May 4, 2024
1 check passed
@fracalrod3 fracalrod3 deleted the fix/259-attendence-volunteer branch May 4, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claugp06 claugp06 claugp06 approved these changes

@fracalrod3 fracalrod3 fracalrod3 approved these changes

Assignees

@manbarjim2 manbarjim2

Labels
bug Something isn't working
Projects
None yet
Milestone
PPL
Development

Successfully merging this pull request may close these issues.

Fix/259-attendence-volunteer
3 participants
@manbarjim2 @claugp06 @fracalrod3