Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/54 asociationdropdown2 #68

Merged
merged 11 commits into from
Mar 3, 2024
Merged

Feature/54 asociationdropdown2 #68

merged 11 commits into from
Mar 3, 2024

Conversation

ivaramlar
Copy link
Contributor

Implemented WhereWeAre and ColaboratorsEntities classes.

@claugp06 claugp06 self-requested a review March 2, 2024 08:42
@claugp06 claugp06 added this to the Sprint 1 milestone Mar 2, 2024
@claugp06 claugp06 added the enhancement New feature or request label Mar 2, 2024
@claugp06 claugp06 linked an issue Mar 2, 2024 that may be closed by this pull request
Feature/54-AsociationDropdown2 #54
Closed
claugp06
claugp06 requested changes Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screen for where we are does not follow the same style as the other screens. You should use the same container as the one in the home page.
The part of the entities that collaborates looks good and it is a good idea to include the link to navigate to them.

@ivaramlar ivaramlar requested a review from claugp06 March 2, 2024 16:39
claugp06
claugp06 approved these changes Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks good. Well done.

@fracalrod3 fracalrod3 self-requested a review March 3, 2024 10:09
fracalrod3
fracalrod3 approved these changes Mar 3, 2024
View reviewed changes
Copy link
Contributor

@fracalrod3 fracalrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright

claugp06
claugp06 approved these changes Mar 3, 2024
View reviewed changes
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, now you can merge

samrodman
samrodman previously requested changes Mar 3, 2024
View reviewed changes
Copy link
Contributor

@samrodman samrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, well done. Just two minor things:
There seem to be two links to Dónde Estamos in the dropdown of the header (see image)
Also on the Where we are page you forgot the accent on Dónde.
image

@manbarjim2 manbarjim2 self-requested a review March 3, 2024 16:28
@claugp06 claugp06 self-requested a review March 3, 2024 16:29
manbarjim2
manbarjim2 approved these changes Mar 3, 2024
View reviewed changes
Copy link
Contributor

@manbarjim2 manbarjim2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like good

fracalrod3
fracalrod3 approved these changes Mar 3, 2024
View reviewed changes
Copy link
Contributor

@fracalrod3 fracalrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine

claugp06
claugp06 requested changes Mar 3, 2024
View reviewed changes
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dropdown values appears two times
image

@claugp06 claugp06 requested review from claugp06 and samrodman and removed request for samrodman March 3, 2024 20:20
claugp06
claugp06 approved these changes Mar 3, 2024
View reviewed changes
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok now

samrodman
samrodman approved these changes Mar 3, 2024
View reviewed changes
Copy link
Contributor

@samrodman samrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good now thanks

@claugp06 claugp06 merged commit 428d151 into develop Mar 3, 2024
1 check passed
@claugp06 claugp06 deleted the feature/54-asociationdropdown2 branch March 4, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fracalrod3 fracalrod3 fracalrod3 approved these changes

@claugp06 claugp06 claugp06 approved these changes

@samrodman samrodman samrodman approved these changes

@manbarjim2 manbarjim2 Awaiting requested review from manbarjim2

Assignees

@ivaramlar ivaramlar

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging this pull request may close these issues.

Feature/54-AsociationDropdown2
5 participants
@ivaramlar @samrodman @manbarjim2 @claugp06 @fracalrod3