First pull request #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskonst
requested changes
Nov 18, 2023
| public price: number; | ||
| constructor(name: string, price: number){ | ||
| this.name = name; | ||
| this.price = price; |
There was a problem hiding this comment.
я могу создать сервис с отрицательной ценой ....
There was a problem hiding this comment.
добавляйте set и get и используйте их в конструкторе
|
|
||
| constructor(name: string, price: number, public mass?:number){ | ||
| super(name, price) | ||
| this.mass = mass |
There was a problem hiding this comment.
значит я могу отрицательные значения mass выставить?
| } | ||
|
|
||
| deleteIngredient(ingredient: string | number){ | ||
| if (typeof ingredient == "string"){ |
There was a problem hiding this comment.
вот это может вести к 2 методам DeleteByID и DeleteByName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Сделано 1 задание на классы. Сделано наследование. Сделаны первые тесты (ожидается больше). Удален класс (Phone) и все связанное с ним. Начато задание RPG Saga (пока не смотреть, так как есть проблема с линтерами)